-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ssl verify #19
Fix ssl verify #19
Conversation
The original code did not actually set the ssl configs which manticore uses for cert verification (:verify).
Option for ssl_certificate_validation is by default set to 'strict'.
Set ssl verify to strict, to match manticore
CLA Signed. |
Shall I rebase? |
Dang, so this repo was possibly finally fixed 19 days ago (actually need to verify) but no comment here. Would have been nice to see at least one heads up from the repo maintainers here so I can either test or update my servers. 👎 |
@JasonGiedymin apologies for the long delay, but this PR slipped through the tracks. Would you mind rebasing? I'll get this merged in ASAP. |
Will do. I will verify that this "bug" still exists or not. -Jason
|
@JasonGiedymin the current option definitely does not work, but thanks for verifying! |
@JasonGiedymin actually, it looks like this only applies to hostname verification. Ideally this would work like |
I don't know if this is actually possible with manticore as-is. I've opened the following ticket cheald/manticore#53 |
Closing this given that this is not currently possible to implement with manticore. This option was deprecated in #25 Thanks for the work @JasonGiedymin . If you have the interest in patching manticore we'd love to take a new patch! |
The original code did not actually set the ssl configs which manticore uses for cert verification (:verify).
The option is by default set to strict.