Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl verify #19

Conversation

JasonGiedymin
Copy link

The original code did not actually set the ssl configs which manticore uses for cert verification (:verify).
The option is by default set to strict.

The original code did not actually set the ssl configs which manticore uses for cert verification (:verify).
Option for ssl_certificate_validation is by default set to 'strict'.
Set ssl verify to strict, to match manticore
@JasonGiedymin
Copy link
Author

CLA Signed.

@JasonGiedymin
Copy link
Author

Shall I rebase?

@JasonGiedymin
Copy link
Author

Dang, so this repo was possibly finally fixed 19 days ago (actually need to verify) but no comment here. Would have been nice to see at least one heads up from the repo maintainers here so I can either test or update my servers. 👎

@andrewvc
Copy link
Contributor

@JasonGiedymin apologies for the long delay, but this PR slipped through the tracks. Would you mind rebasing? I'll get this merged in ASAP.

@suyograo suyograo added the P1 label Jul 19, 2016
@JasonGiedymin
Copy link
Author

Will do. I will verify that this "bug" still exists or not.

-Jason

On Jul 19, 2016, at 4:22 PM, Andrew Cholakian [email protected] wrote:

@JasonGiedymin apologies for the long delay, but this PR slipped through the tracks. Would you mind rebasing? I'll get this merged in ASAP.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@andrewvc
Copy link
Contributor

@JasonGiedymin the current option definitely does not work, but thanks for verifying!

@andrewvc
Copy link
Contributor

@JasonGiedymin actually, it looks like this only applies to hostname verification. Ideally this would work like curl -k. I'm going to research this a bit more.

@andrewvc
Copy link
Contributor

I don't know if this is actually possible with manticore as-is. I've opened the following ticket cheald/manticore#53

@andrewvc andrewvc self-assigned this Aug 5, 2016
@andrewvc
Copy link
Contributor

andrewvc commented Aug 5, 2016

Closing this given that this is not currently possible to implement with manticore. This option was deprecated in #25

Thanks for the work @JasonGiedymin . If you have the interest in patching manticore we'd love to take a new patch!

@andrewvc andrewvc closed this Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants