Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Actions instead TravisCI #48

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Use GitHub Actions instead TravisCI #48

merged 1 commit into from
Oct 21, 2021

Conversation

roseliux
Copy link
Contributor

@roseliux roseliux commented Oct 20, 2021 •
edited
Loading

Closes #47

@sourcelevel-bot
Copy link

Hello, @roseliux! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@roseliux roseliux mentioned this pull request Oct 20, 2021
Closed
@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 69 possible new issues (including those that may have been commented here).
  • 3 fixed issues! 🎉

See more details about this review.

@VictorSNA
Copy link
Contributor

Seems some tests are broken in Github Actions CI:

https://github.com/roseliux/cassette/runs/3945966327

@VictorSNA VictorSNA linked an issue Oct 21, 2021 that may be closed by this pull request
Drops support for EOL rubies and adds for newers versions! #45
Open
@VictorSNA VictorSNA removed a link to an issue Oct 21, 2021
Drops support for EOL rubies and adds for newers versions! #45
Open
VictorSNA
VictorSNA suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@VictorSNA VictorSNA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, we need to fix broken tests!

@roseliux
Use GitHub Actions instead TravisCI
f11660e 
- Remove travis and add github workflows ci
- Require 'active_support/notifications' to fix uninitialized constant ActiveSupport::Notifications
@roseliux
Copy link
Contributor Author

roseliux commented Oct 21, 2021 •
edited
Loading

Hello @VictorSNA can you review again?
I fixed broken test https://github.com/roseliux/cassette/actions/runs/1368950811

@roseliux roseliux requested a review from VictorSNA October 21, 2021 17:21
VictorSNA
VictorSNA approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@VictorSNA VictorSNA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks a lot @roseliux!

@VictorSNA VictorSNA merged commit 4e825e2 into locaweb:master Oct 21, 2021
@roseliux roseliux deleted the use-github-actions branch October 21, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorSNA VictorSNA VictorSNA approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GitHub Actions instead TravisCI
2 participants
@roseliux @VictorSNA