Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Updated token values #1664

Closed
wants to merge 88 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
28d6177
BREAKING CHANGE(design-tokens): Introduce new design tokens structure…
crishpeen Aug 16, 2024
0c34b54
Test: Temporarily disable all visual tests and SCSS loading
crishpeen Aug 16, 2024
91ef2a6
BREAKING CHANGE(web): Introduce themes and use new design tokens for …
crishpeen Aug 18, 2024
6256793
Feat(web): Switch Demo styles to v3 design tokens structure #DS-1430
crishpeen Aug 19, 2024
06c3c16
Feat(web-twig): Switch Demo styles to v3 design tokens structure #DS-…
crishpeen Aug 27, 2024
93e81db
Feat(web): Switch Container and Grid styles to v3 design tokens struc…
crishpeen Aug 19, 2024
3a413bc
Docs(web,web-react,web-twig): Switch Grid spacing tokens to v3 structure
crishpeen Aug 19, 2024
ed7a5eb
Feat(web): Switch Collapse, Divider, Stack, ActionLayout & EmptyState…
crishpeen Aug 27, 2024
e005864
Docs(web,web-react,web-twig): Switch to v3 spacings in Tabs #DS-1444
crishpeen Aug 27, 2024
864ba81
Feat(web): Switch Tabs to v3 design tokens #DS-1444
crishpeen Aug 27, 2024
6ab575c
Feat(web): Switch `Breadcrumbs` component to v3 design tokens #DS-1450
adamkudrna Aug 29, 2024
ada0276
Feat(web): Switch PartnerLogo component to v3 design tokens #DS-1450
crishpeen Aug 29, 2024
d401a49
Feat(storybook): Add themes to Storybook
crishpeen Aug 30, 2024
0137298
Feat(web): Switch Flex component to v3 design tokens #DS-1444
crishpeen Aug 28, 2024
ac0959a
Docs(web-react): Use correct typography helper and spacings in Flex #…
crishpeen Sep 5, 2024
4167f94
BREAKING CHANGE(web): Remove inverted variant of `ProductLogo` #DS-1450
adamkudrna Aug 29, 2024
c97e7df
BREAKING CHANGE(web-react): Remove inverted variant of `ProductLogo` …
adamkudrna Aug 29, 2024
7b89c7a
Feat(web): Switch Dropdown component to v3 design tokens #DS-1450
crishpeen Aug 30, 2024
d91227c
Feat(web): Switch Avatar component to v3 design tokens #DS-1450
crishpeen Aug 29, 2024
83d4cca
Docs(web-react): Switch Avatar demo spacings to v3 design token value…
crishpeen Aug 29, 2024
068cc2f
Docs: Set default background color to main element in demos
crishpeen Aug 27, 2024
39d9d85
BREAKING CHANGE(web): Switch Button to v3 design tokens and remove in…
crishpeen Aug 27, 2024
aa51adc
BREAKING CHANGE(web-react): Remove inverted variant from Button and B…
crishpeen Aug 27, 2024
9b009f0
BREAKING CHANGE(web-twig): Remove inverted variant from Button and Bu…
crishpeen Aug 27, 2024
d26d6c2
Test: Enable visual testing of components and pages with Button
crishpeen Aug 31, 2024
12c1c53
Feat(web): Switch Alert component to v3 design tokens #DS-1446
crishpeen Aug 28, 2024
e6d66b3
Feat(web): Stabilization of ProductLogo component #DS-1374
pavelklibani Sep 5, 2024
988f2df
Feat(web-react): Stabilization of ProductLogo component #DS-1374
pavelklibani Sep 5, 2024
ee0cdd4
Feat(e2e): Update visual tests for ProductLogo #DS-1374
pavelklibani Sep 5, 2024
f5a57b3
Feat(web): Switch Pagination component to v3 design tokens #DS-1450
crishpeen Sep 3, 2024
c84bff7
Feat(web): Switch ScrollView component to v3 design tokens #DS-1451
crishpeen Sep 2, 2024
100dc2a
Docs(web-react,web-twig): Use new spacing tokens values in ScrollView…
crishpeen Sep 2, 2024
e9329d5
Feat(web): Switch Accordion component to v3 design tokens #DS-1451
crishpeen Sep 3, 2024
01447ce
Feat(web): Class modifier `hasSafeAreaDisabled` changed to `safeArea`…
pavelklibani Sep 6, 2024
b925784
Feat(web-react): Prop `hasSafeAreaDisabled` changed to `hasSafeArea` …
pavelklibani Sep 6, 2024
74719a1
Feat(web): Switch Tag component to v3 design tokens #DS-1445
crishpeen Sep 5, 2024
442d774
Test: Update visual tests of Section and Collapse
crishpeen Sep 10, 2024
361c22e
Feat(web): Switch Modal component to v3 design tokens #DS-1452
crishpeen Sep 5, 2024
861d49c
Feat(web-react): Stabilization of PartnerLogo component #DS-1443
curdaj Sep 13, 2024
7aee605
Feat(web): Stabilization of PartnerLogo component #DS-1443
curdaj Sep 13, 2024
150d7ff
Feat(web): Introduce background image urls generator to themes #DS-1447
crishpeen Aug 31, 2024
052fdec
Feat(web): Switch Checkbox component to v3 design tokens #DS-1447
crishpeen Aug 31, 2024
f80de66
BREAKING CHANGE(web): Switch TextField component to v3 design tokens …
crishpeen Sep 10, 2024
9ad4fa8
Feat(web): Switch Radio component to v3 design tokens #DS-1447
crishpeen Sep 2, 2024
a86c36a
Feat(web): Switch Select component to v3 design tokens #DS-1447
crishpeen Sep 12, 2024
602d28a
Feat(web): Switch TextArea component to v3 design tokens #DS-1447
crishpeen Sep 12, 2024
02f3b68
BREAKING CHANGE(web): Remove action colors from Pill and switch it to…
crishpeen Sep 7, 2024
bf2b68d
BREAKING CHANGE(web-react): Remove action colors from Pill #DS-1446
crishpeen Sep 7, 2024
4ca09c6
BREAKING CHANGE(web-twig): Remove action colors from Pill #DS-1446
crishpeen Sep 7, 2024
8ea2e9d
Feat(web): Switch Tooltip component to v3 design tokens #DS-1451
crishpeen Sep 3, 2024
2192ad3
Docs(web-react,web-twig): Use new spacing tokens values in Tooltip #D…
crishpeen Sep 3, 2024
0ee06f1
BREAKING CHANGE(web): Switch FieldGroup component to v3 design tokens…
crishpeen Sep 12, 2024
6bc495a
BREAKING CHANGE(web): Switch Link and typography helpers to v3 design…
crishpeen Sep 7, 2024
01d3cc3
BREAKING CHANGE(web-react): Switch Link, Heading and Text to v3 desig…
crishpeen Sep 7, 2024
a39e1fe
BREAKING CHANGE(web-twig): Switch Link, Heading and Text to v3 design…
crishpeen Sep 7, 2024
06213d8
Feat(web): Switch FileUploader component to v3 design tokens #DS-1448
crishpeen Sep 12, 2024
6aa28f1
Feat(web): Switch Item component to v3 design tokens #DS-1451
crishpeen Sep 17, 2024
a0ca266
Feat(web): Switch Footer component to v3 design tokens
crishpeen Sep 19, 2024
39ef786
Feat(web-react): Switch Footer component to v3 design tokens
crishpeen Oct 1, 2024
5bd7283
Feat(web): Switch Slider component to v3 design tokens #DS-1449
crishpeen Sep 17, 2024
d4c27f5
Test(e2e): Enable visual testing of rest of the components
crishpeen Sep 17, 2024
5dc98c2
BREAKING CHANGE(web): Switch Toast component to v3 design tokens #DS-…
crishpeen Sep 19, 2024
7ebd905
BREAKING CHANGE(web-twig): Rename `inverted` variant of `Toast` to `n…
crishpeen Sep 24, 2024
075ff2a
BREAKING CHANGE(web-react): Rename `inverted` variant of `Toast` to `…
crishpeen Sep 24, 2024
ece7ad5
Feat(web): Switch Toggle component to v3 design tokens #DS-1449
crishpeen Sep 24, 2024
a19f93e
Docs(web-react): Add more disabled combinations to Toggle demo #DS-1449
crishpeen Sep 24, 2024
eb48b67
BREAKING CHANGE(web): Switch `Header` component to v3 design tokens #…
adamkudrna Sep 19, 2024
a66ce77
BREAKING CHANGE(web-react): Switch `Header` component to v3 design to…
adamkudrna Sep 19, 2024
bcad6c9
BREAKING CHANGE(web-twig): Switch `Header` component to v3 design tok…
adamkudrna Sep 19, 2024
6c3b27d
Test(e2e): Enable Modal visual testing using v3 tokens
crishpeen Oct 1, 2024
3e6f21e
Docs(form-validations,web,web-react): Redesign the demo app #DS-1479
adamkudrna Oct 1, 2024
fcb187d
Docs(web-twig): Redesign the demo app #DS-1479
adamkudrna Oct 1, 2024
b757183
Test(web): Allow SASS Unit tests to run again
crishpeen Sep 26, 2024
c223079
Docs(form-validations,web,web-react): Add theme switcher to the demo …
adamkudrna Oct 1, 2024
4f36c84
Docs(web-twig): Add theme switcher to the demo app #DS-1479
adamkudrna Oct 1, 2024
70dbed9
Test(web,web-react): Update visual snapshots after demo apps redesign…
adamkudrna Oct 1, 2024
1d4cc3f
BREAKING CHANGE(web-react): Button/ButtonLink have isSymmetrical prop…
curdaj Oct 2, 2024
3ffe404
BREAKING CHANGE(web): Button has isSymmetrical prop instead of isSqua…
curdaj Oct 2, 2024
8f566f7
BREAKING CHANGE(web-twig): Button/ButtonLink have isSymmetrical prop …
curdaj Oct 2, 2024
d058a36
Feat(codemods): Button and ButtonLink have isSymmetrical prop instead…
curdaj Oct 3, 2024
852b0e6
Docs: Button and ButtonLink have isSymmetrical prop instead of isSqua…
curdaj Oct 4, 2024
27aae11
Feat(design-tokens): New tokens
crishpeen Sep 26, 2024
76eb108
Feat(web-react): Rename space to spaces in tokens import
crishpeen Oct 8, 2024
faba222
Feat(web): Use correct focus shadow in Slider
crishpeen Sep 26, 2024
1a82834
Feat(web): Use correct focus shadow in Radio
crishpeen Sep 26, 2024
081b5d9
Feat(web): Use correct focus shadow in forms
crishpeen Sep 26, 2024
30bbddb
Feat(web): Use correct focus shadow in Toggle
crishpeen Oct 3, 2024
8836d8b
Docs(design-tokens): Update theme names
crishpeen Oct 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
11 changes: 11 additions & 0 deletions apps/demo/config/vite/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ export default defineConfig({
},
runtimeOptions: {
data: {
themes: [
{
id: 'light-default',
name: 'Light Default',
},
{
id: 'light-on-brand',
name: 'Light on Brand',
},
],
is_development: process.env.NODE_ENV === 'development',
// Get the list of components directories and pass their names to the data
web_components: getListOfNestedDirectories('../../packages/web/src/scss/components', 'index.html'),
// Get the list of helpers directories and pass their names to the data
Expand Down
5 changes: 0 additions & 5 deletions apps/demo/partials/boxList.hbs

This file was deleted.

5 changes: 5 additions & 0 deletions apps/demo/partials/card.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<li class="d-grid">
<a href="{{path}}/{{urlname}}/" class="docs-Card text-truncate">
{{content}}
</a>
</li>
5 changes: 5 additions & 0 deletions apps/demo/partials/cardList.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<ul class="Grid Grid--cols-2 Grid--tablet--cols-3">

{{> @partial-block}}

</ul>
3 changes: 0 additions & 3 deletions apps/demo/partials/component.hbs

This file was deleted.

50 changes: 50 additions & 0 deletions apps/demo/partials/cover.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<div class="spirit-theme-light-on-brand bg-primary mb-tablet-1200 py-1200 py-tablet-1700 {{#unless (eq page 'components')}}hide-from-visual-tests{{/unless}}">
<div class="Container">

<h1
class="Flex Flex--noWrap Flex--alignmentXStretch Flex--alignmentYCenter Flex--row typography-heading-xlarge-bold"
style="--flex-spacing: var(--spirit-space-1000)"
>
{{title}}

{{#if isUnstable}}
<span class="Tag Tag--large Tag--warning">Unstable</span>
{{/if}}
</h1>

<nav aria-label="Breadcrumbs" class="Breadcrumbs">
<ol>
<li class="d-flex">
<a href="/" class="link-primary link-underlined">Spirit</a>
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#chevron-right" />
</svg>
</li>
{{#if package}}
<li class="d-flex">
<a href="{{packageUrl}}" class="link-primary link-underlined">{{package}}</a>
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#chevron-right" />
</svg>
</li>
{{/if}}
{{#if parentPageName}}
<li class="d-flex">
<a href="{{#if (eq parentPageName 'Components') }}{{packageUrl}}{{else}}..{{/if}}" class="link-primary link-underlined">
{{parentPageName}}
</a>
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#chevron-right" />
</svg>
</li>
{{/if}}
{{#if title}}
<li class="d-flex">
<a href="" aria-current="page" class="link-secondary">{{title}}</a>
</li>
{{/if}}
</ol>
</nav>

</div>
</div>
7 changes: 7 additions & 0 deletions apps/demo/partials/footer.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<footer class="bg-secondary mt-1200 mt-tablet-1700 pt-1400 pb-1200 text-center {{#unless (eq page 'components')}}hide-from-visual-tests{{/unless}}">
<div class="Container">

© Alma Career Oy and its subsidiaries

</div>
</footer>
16 changes: 16 additions & 0 deletions apps/demo/partials/form-validations/layout/default.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{{#> layout/base package="Form Validations" packageUrl="/packages/form-validations/" title=title}}

{{> header}}
{{> cover}}

<main class="py-1000">
<div class="Container">

{{> @partial-block}}

</div>
</main>

{{> footer}}

{{/layout/base}}
159 changes: 144 additions & 15 deletions apps/demo/partials/header.hbs
Original file line number Diff line number Diff line change
@@ -1,20 +1,149 @@
<header class='bg-inverted text-secondary-inverted py-1000 py-tablet-1100'>
<div class='Container'>
<header class="Header spirit-theme-light-on-brand {{#unless (eq page 'components')}}hide-from-visual-tests{{/unless}}">
<a href="/" aria-label="Spirit Development Preview">
{{> web/assets/spiritLogoInverted }}
</a>

<h1 class='typography-heading-xlarge-text'>Spirit Design System</h1>
<h2 class='typography-heading-medium-text text-secondary-inverted-disabled mb-900'>{{#if package}}{{package}} - {{/if}}Development Preview</h2>
<!-- HeaderMobileActions: start -->
<div class="HeaderMobileActions">
<button
type="button"
class="Button Button--secondary Button--medium Button--square"
data-spirit-toggle="offcanvas"
data-spirit-target="#off-canvas-navigation"
aria-controls="off-canvas-navigation"
aria-expanded="false"
>
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#hamburger" />
</svg>
<span class="accessibility-hidden">Menu</span>
</button>
</div>
<!-- HeaderMobileActions: end -->

<!-- HeaderDesktopActions: start -->
<nav class="HeaderDesktopActions" aria-label="Main navigation">
<!-- HeaderNav: start -->
<ul class="HeaderNav">
<li class="HeaderNavItem">
<a
href="/packages/web/"
class="HeaderLink {{# if (eq package 'Web')}}HeaderLink--current{{/if}}"
{{# if (eq package 'Web')}}aria-current="page"{{/if}}
>
Web
</a>
</li>
<li class="HeaderNavItem">
<a
href="/packages/web-react/"
class="HeaderLink {{# if (eq package 'Web React')}}HeaderLink--current{{/if}}"
{{# if (eq package 'Web React')}}aria-current="page"{{/if}}
>
Web React
</a>
</li>
{{!-- Hide link to the Twig implementation in production. Twig demo app only runs on localhost, we don't deploy it anywhere. --}}
{{!-- For the same reason, we don't include the link in the visual tests. --}}
{{#if @is_development}}
<li class="HeaderNavItem hide-from-visual-tests">
<a href="https://localhost:4443" class="HeaderLink">Web Twig</a>
</li>
{{/if}}
<li class="HeaderNavItem">
<a
href="/packages/form-validations/"
class="HeaderLink {{# if (eq package 'Form Validations')}}HeaderLink--current{{/if}}"
{{# if (eq package 'Form Validations')}}aria-current="page"{{/if}}
>
Form Validations
</a>
</li>
</ul>
<!-- HeaderNav: end -->
</nav>
<!-- HeaderDesktopActions: end -->

<!-- HeaderDesktopActions: start -->
<nav class="HeaderDesktopActions HeaderDesktopActions--end">

{{> themeSwitcher isLabelHidden=true}}

<div class='d-grid d-tablet-block'>
<a
href='https://github.com/lmc-eu/spirit-design-system'
class='Button Button--inverted Button--large mb-400 mb-tablet-0 mr-tablet-400'
</nav>
<!-- HeaderDesktopActions: end -->
</header>

<!-- HeaderDialog: start -->
<dialog id="off-canvas-navigation" class="HeaderDialog" aria-label="Menu">
<div class="HeaderDialog__panel">
<div class="HeaderDialog__content">

<!-- HeaderDialogCloseButton: start -->
<button
type="button"
class="HeaderDialogCloseButton"
data-spirit-dismiss="off-canvas-navigation"
data-spirit-target="#off-canvas-navigation"
aria-controls="off-canvas-navigation"
aria-expanded="false"
>
GitHub Project
</a>
<a href='https://spirit.supernova-docs.io/spirit/' class='Button Button--inverted Button--large'>
Spirit Docs →
</a>
</div>
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#close" />
</svg>
<span class="accessibility-hidden">Close</span>
</button>
<!-- HeaderDialogCloseButton: end -->

<!-- HeaderDialogActions: start -->
<nav class="HeaderDialogActions HeaderDialogActions--primary" aria-label="Main navigation">

<!-- HeaderDialogNav: start -->
<ul class="HeaderDialogNav">
<li class="HeaderDialogNavItem">
<a
href="/packages/web/"
class="HeaderDialogLink {{# if (eq package 'Web')}}HeaderDialogLink--current{{/if}}"
{{# if (eq package 'Web')}}aria-current="page"{{/if}}
>
Web
</a>
</li>
<li class="HeaderDialogNavItem">
<a
href="/packages/web-react/"
class="HeaderDialogLink {{# if (eq package 'Web React')}}HeaderDialogLink--current{{/if}}"
{{# if (eq package 'Web React')}}aria-current="page"{{/if}}
>
Web React
</a>
</li>
{{!-- Hide link to the Twig implementation in production. Twig demo app only runs on localhost, we don't deploy it anywhere. --}}
{{#if @is_development}}
<li class="HeaderDialogNavItem">
<a href="https://localhost:4443" class="HeaderDialogLink">Web Twig</a>
</li>
{{/if}}
<li class="HeaderDialogNavItem">
<a
href="/packages/form-validations/"
class="HeaderDialogLink {{# if (eq package 'Form Validations')}}HeaderDialogLink--current{{/if}}"
{{# if (eq package 'Form Validations')}}aria-current="page"{{/if}}
>
Form Validations
</a>
</li>
</ul>
<!-- HeaderDialogNav: end -->

</nav>
<nav class="HeaderDialogActions HeaderDialogActions--secondary" aria-label="Secondary navigation">

{{> themeSwitcher isLabelHidden=false}}

</nav>
<!-- HeaderDialogActions: end -->

</div>
</div>
</header>
</dialog>
<!-- HeaderDialog: end -->
33 changes: 31 additions & 2 deletions apps/demo/partials/layout/base.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover">
<title>{{#if package}}{{package}} - {{/if}}Development Preview</title>
<title>
{{#if title}}
{{title}} —
{{#if package}}{{package}} —{{/if}}
Spirit Design System
{{else}}
Spirit Design System — Development preview
{{/if}}
</title>

<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
Expand All @@ -19,11 +27,32 @@
<link rel="stylesheet" href="https://fonts.googleapis.com/css2?family=Inter:wght@400;600;700&display=block">
<link rel="stylesheet" href="/apps/demo/assets/index.scss">

<script src="/packages/web/src/js/index.esm.ts" type="module"></script>

<!-- Theme switcher -->
<script>
const themes = [];

{{#each @themes as |theme|}}
themes.push('{{theme.id}}');
{{/each}}

const switchTheme = (event) => {
const targetElement = document.body;
const theme = event.target.value;

themes.forEach((theme) => {
targetElement.classList.remove(`spirit-theme-${theme}`);
});
targetElement.classList.add(`spirit-theme-${theme}`);
};
</script>

{{#> scripts}}
{{/scripts}}

</head>
<body>
<body class="bg-primary">

{{> @partial-block}}

Expand Down
20 changes: 0 additions & 20 deletions apps/demo/partials/layout/default.hbs

This file was deleted.

11 changes: 0 additions & 11 deletions apps/demo/partials/layout/plain.hbs

This file was deleted.

7 changes: 0 additions & 7 deletions apps/demo/partials/section.hbs

This file was deleted.

15 changes: 15 additions & 0 deletions apps/demo/partials/themeSwitcher.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<div class="Select Select--fluid">
<label for="select-theme" class="Select__label {{#if isLabelHidden }}Select__label--hidden{{/if}}">Theme</label>
<div class="Select__inputContainer">
<select id="select-theme" name="theme" class="Select__input" onchange="switchTheme(event)" autocomplete="off">
{{#each @themes as |theme|}}
<option value="{{theme.id}}">{{theme.name}}</option>
{{/each}}
</select>
<div class="Select__icon">
<svg width="24" height="24" aria-hidden="true">
<use xlink:href="/assets/icons/svg/sprite.svg#chevron-down" />
</svg>
</div>
</div>
</div>
5 changes: 0 additions & 5 deletions apps/demo/partials/tileList.hbs

This file was deleted.

Loading
Loading