Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Updated token values #1664

Closed
wants to merge 88 commits into from
Closed

WIP Updated token values #1664

wants to merge 88 commits into from

Conversation

crishpeen
Copy link
Member

Description

Token values based on current Figma state.

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Sep 26, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 8836d8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67052ed29325ee00088cba50

@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8836d8b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67052ed1e42995000825eff0
😎 Deploy Preview https://deploy-preview-1664--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 26, 2024 •
edited
Loading

Coverage Status

coverage: 78.782%. remained the same
when pulling 8836d8b on feat/new-tokens
into 852b0e6 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the test/sass-unit-reenable branch from 200fb65 to c16fe45 Compare October 1, 2024 08:01
@crishpeen crishpeen force-pushed the test/sass-unit-reenable branch from c16fe45 to f76b3e2 Compare October 1, 2024 11:29
@crishpeen crishpeen force-pushed the test/sass-unit-reenable branch from f76b3e2 to 888e822 Compare October 1, 2024 11:39
@crishpeen crishpeen force-pushed the test/sass-unit-reenable branch from 888e822 to 41a20e1 Compare October 3, 2024 08:55
Base automatically changed from test/sass-unit-reenable to integration/BC-v3-design-tokens October 3, 2024 10:56
crishpeen and others added 16 commits October 8, 2024 11:35
@crishpeen
BREAKING CHANGE(design-tokens): Introduce new design tokens structure…
28d6177 
… #DS-1430
@crishpeen
Test: Temporarily disable all visual tests and SCSS loading
0c34b54
@crishpeen
BREAKING CHANGE(web): Introduce themes and use new design tokens for …
91ef2a6 
…foundations #DS-1431
@crishpeen
Feat(web): Switch Demo styles to v3 design tokens structure #DS-1430
6256793
@crishpeen
Feat(web-twig): Switch Demo styles to v3 design tokens structure #DS-…
06c3c16 
…1430
@crishpeen
Feat(web): Switch Container and Grid styles to v3 design tokens struc…
93e81db 
…ture
@crishpeen
Docs(web,web-react,web-twig): Switch Grid spacing tokens to v3 structure
3a413bc
@crishpeen
Feat(web): Switch Collapse, Divider, Stack, ActionLayout & EmptyState…
ed7a5eb 
… to v3 design tokens #DS-1444
@crishpeen
Docs(web,web-react,web-twig): Switch to v3 spacings in Tabs #DS-1444
e005864
@crishpeen
Feat(web): Switch Tabs to v3 design tokens #DS-1444
864ba81
@adamkudrna @crishpeen
Feat(web): Switch Breadcrumbs component to v3 design tokens #DS-1450
6ab575c
@crishpeen
Feat(web): Switch PartnerLogo component to v3 design tokens #DS-1450
ada0276
@crishpeen
Feat(storybook): Add themes to Storybook
d401a49
@crishpeen
Feat(web): Switch Flex component to v3 design tokens #DS-1444
0137298
@crishpeen
Docs(web-react): Use correct typography helper and spacings in Flex #…
ac0959a 
…DS-1444
@adamkudrna @crishpeen
BREAKING CHANGE(web): Remove inverted variant of ProductLogo #DS-1450
4167f94
adamkudrna and others added 14 commits October 8, 2024 11:35
@adamkudrna @crishpeen
BREAKING CHANGE(web-react): Switch Header component to v3 design to…
a66ce77 
…kens #DS-1453
@adamkudrna @crishpeen
BREAKING CHANGE(web-twig): Switch Header component to v3 design tok…
bcad6c9 
…ens #DS-1453
@crishpeen
Test(e2e): Enable Modal visual testing using v3 tokens
6c3b27d
@adamkudrna @crishpeen
Docs(form-validations,web,web-react): Redesign the demo app #DS-1479
3e6f21e 
Include header and footer on all demo pages for easier navigation.
@adamkudrna @crishpeen
Docs(web-twig): Redesign the demo app #DS-1479
fcb187d 
Include header and footer on all demo pages for easier navigation.
@crishpeen
Test(web): Allow SASS Unit tests to run again
b757183
@adamkudrna @crishpeen
Docs(form-validations,web,web-react): Add theme switcher to the demo …
c223079 
…app #DS-1479
@adamkudrna @crishpeen
Docs(web-twig): Add theme switcher to the demo app #DS-1479
4f36c84
@adamkudrna @crishpeen
Test(web,web-react): Update visual snapshots after demo apps redesign…
70dbed9 
… #DS-1479

Hide site header and footer from component snapshots.
@curdaj @crishpeen
BREAKING CHANGE(web-react): Button/ButtonLink have isSymmetrical prop…
1d4cc3f 
… instead of isSquare #DS-1484
@curdaj @crishpeen
BREAKING CHANGE(web): Button has isSymmetrical prop instead of isSqua…
3ffe404 
…re #DS-1484
@curdaj @crishpeen
BREAKING CHANGE(web-twig): Button/ButtonLink have isSymmetrical prop …
8f566f7 
…instead of isSquare #DS-1484
@curdaj @crishpeen
Feat(codemods): Button and ButtonLink have isSymmetrical prop instead…
d058a36 
… of isSquare #DS-1484
@curdaj @crishpeen
Docs: Button and ButtonLink have isSymmetrical prop instead of isSqua…
852b0e6 
…re #DS-1484
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 65ae9e3 to 852b0e6 Compare October 8, 2024 09:36
@literat literat force-pushed the integration/BC-v3-design-tokens branch 4 times, most recently from 912c9b2 to f5ad8a7 Compare October 17, 2024 14:17
@crishpeen
Copy link
Member Author

Will be solved in #1722

@crishpeen crishpeen closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @adamkudrna @pavelklibani @curdaj