Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo HP and visual tests only include pages with index.html (or *.stories.twig) #1302

Merged
merged 3 commits into from
Mar 4, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docs(web-react): Do not list components that don't have index.html on…
… Demo homepage #DS-1185

Remove manually controlled list.
  • Loading branch information
crishpeen committed Feb 29, 2024
commit 514e49ef9891e0922adba178c295d8028230f0ab
4 changes: 1 addition & 3 deletions packages/web-react/config/vite/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { defineConfig } from 'vite';
import handlebars from 'vite-plugin-handlebars';
import { getNestedDirs } from '../../scripts/build';

const hiddenDemoComponents = ['Field', 'Dialog', 'Icon', 'NoSsr', 'TextFieldBase', 'VisuallyHidden'];

export default defineConfig({
// Disable HMR overlay to avoid flaky screenshots in visual regression tests
server: {
Expand All @@ -29,7 +27,7 @@ export default defineConfig({
components: [
...readdirSync('src/components', { withFileTypes: true })
.filter((item) => item.isDirectory())
.filter((item) => !hiddenDemoComponents.includes(item.name))
.filter((item) => readdirSync(`src/components/${item.name}`).includes('index.html'))
.map((item) => item.name),
],
},
Expand Down