Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo HP and visual tests only include pages with index.html (or *.stories.twig) #1302

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 4d553e0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65e5e2c4083801000807a60f

@crishpeen crishpeen changed the title Bugfix/demo test index Demo HP and visual tests only include pages with index.html (or *.stories.twig) Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 4d553e0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65e5e2c4cedd8b000843ca81

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4d553e0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65e5e2c4b5427200080d1556

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 4d553e0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65e5e2c4e8d9400008e0092e

@coveralls
Copy link

Coverage Status

coverage: 71.175% (-9.0%) from 80.15%
when pulling 94b5446 on bugfix/demo-test-index
into 07742b8 on main.

@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 80.15%. remained the same
when pulling 4d553e0 on bugfix/demo-test-index
into 07742b8 on main.

@crishpeen crishpeen force-pushed the bugfix/demo-test-index branch from 94b5446 to a3b519d Compare February 29, 2024 17:06
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏🏻

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

… their page #DS-1185

Check if index.html or *.stories.twig exist.
Remove manually controlled list.
@crishpeen crishpeen force-pushed the bugfix/demo-test-index branch from aaa7b63 to 4d553e0 Compare March 4, 2024 15:03
@crishpeen crishpeen merged commit ed4df63 into main Mar 4, 2024
20 checks passed
@crishpeen crishpeen deleted the bugfix/demo-test-index branch March 4, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants