Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce stacking of the Toast queue #1298

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Feat(web): Introduce stacking of the Toast queue #1298

merged 1 commit into from
Apr 16, 2024

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Feb 28, 2024 •
edited
Loading

Additional context

Stacking:
image

Collapsing:
image=

Issue reference

https://jira.almacareer.tech/browse/DS-1159

@github-actions github-actions bot added the feature New feature or request label Feb 28, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

❌ Deploy Preview for spirit-design-system-demo failed. Why did it fail? →

Name Link
🔨 Latest commit beaeb51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/66032eaa643ec0000809573d

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

❌ Deploy Preview for spirit-design-system-react failed. Why did it fail? →

Name Link
🔨 Latest commit beaeb51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/66032eaa69f3ee00088ccabf

@adamkudrna adamkudrna changed the title 🚧 Feat(web): Introduce stacking of the queue 🚧 Feat(web): Introduce stacking of the Toast queue Feb 28, 2024
@adamkudrna adamkudrna mentioned this pull request Feb 29, 2024
Merged
@adamkudrna adamkudrna force-pushed the feature/web-toast branch 2 times, most recently from dc491b2 to aeaa60e Compare February 29, 2024 15:55
Base automatically changed from feature/web-toast to main February 29, 2024 16:20
@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch from c3ade44 to ba84762 Compare February 29, 2024 17:02
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit c60866d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/660ebd0f4e402b0008920739

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

❌ Deploy Preview for spirit-design-system-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit c60866d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/660ebd10f429c800078370f7

@coveralls
Copy link

coveralls commented Feb 29, 2024 •
edited
Loading

Coverage Status

coverage: 69.132% (-27.2%) from 96.371%
when pulling d2fc738 on feature/web-toast-stacking
into 0ca4ef1 on integration/toast-queue.

@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch 2 times, most recently from 9600e8d to a244b6c Compare March 7, 2024 16:10
@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch from a244b6c to eddd8e2 Compare March 12, 2024 16:32
@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch from eddd8e2 to beaeb51 Compare March 26, 2024 20:23
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d2fc738
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/661eaec0721c940008bf6369
😎 Deploy Preview https://deploy-preview-1298--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

crishpeen
crishpeen reviewed Apr 2, 2024
View reviewed changes
packages/web/src/js/Toast.ts Outdated Show resolved Hide resolved
packages/web/src/js/__tests__/Toast.test.ts Outdated Show resolved Hide resolved
packages/web/src/js/__tests__/Toast.test.ts Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/_ToastItem.scss Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_dictionaries.scss Show resolved Hide resolved
packages/web/src/scss/components/Toast/README.md Show resolved Hide resolved
packages/web/src/scss/components/Toast/README.md Show resolved Hide resolved
packages/web/src/scss/components/Toast/_Toast.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/_ToastBar.scss Show resolved Hide resolved
packages/web/src/scss/components/Toast/_ToastItem.scss Outdated Show resolved Hide resolved
literat
literat reviewed Apr 3, 2024
View reviewed changes
packages/web/src/js/Toast.ts Outdated Show resolved Hide resolved
packages/web/src/js/Toast.ts Outdated Show resolved Hide resolved
packages/web/src/js/Toast.ts Outdated Show resolved Hide resolved
packages/web/src/js/Toast.ts Outdated Show resolved Hide resolved
@adamkudrna adamkudrna changed the title 🚧 Feat(web): Introduce stacking of the Toast queue Feat(web): Introduce stacking of the Toast queue Apr 4, 2024
@adamkudrna adamkudrna marked this pull request as ready for review April 4, 2024 13:05
@adamkudrna adamkudrna requested review from pavelklibani and a team as code owners April 4, 2024 13:05
@adamkudrna adamkudrna requested review from crishpeen and literat April 4, 2024 13:06
@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch from cc6e54b to c60866d Compare April 4, 2024 14:45
@adamkudrna adamkudrna changed the base branch from main to integration/toast-queue April 4, 2024 14:46
crishpeen
crishpeen approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, great job 💪

packages/web/src/scss/components/Toast/README.md Show resolved Hide resolved
packages/web/src/scss/components/Toast/README.md Show resolved Hide resolved
packages/web/src/scss/components/Toast/_Toast.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/_Toast.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/_ToastItem.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/dynamic-toast.mjs Outdated Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the feature/web-toast-stacking branch from 0ef0626 to d2fc738 Compare April 16, 2024 17:00
@adamkudrna adamkudrna merged commit 86ed8a5 into integration/toast-queue Apr 16, 2024
20 checks passed
@adamkudrna adamkudrna deleted the feature/web-toast-stacking branch April 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamkudrna @coveralls @literat @crishpeen @pavelklibani