-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce the Toast
component #DS-1112
#1293
Conversation
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
Inverted variant has no hover effect on dismiss button? |
Just the border, not the background like in other button variants. Even the change of the border color is almost invisible. See https://spirit-design-system-demo.netlify.app/src/scss/components/button/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing I noticed is that when I open the demo on any of my devices, the floating bars are over the static ones and it is a little bit hard to distinguish them. Maybe at least one of them could be in some emotion color? Also when I switch to top alignment on my phone, I am not able to switch back without reloading. :)
c98a39e
to
b1a3342
Compare
I know. Like this maybe?
Try scrolling the page 🙂. |
Toast
component #DS-1112Toast
component #DS-1112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! You can prepare a talk about Toast for next meetup :))
tests/e2e/demo-components-compare.spec.ts-snapshots/toast-chromium-linux.png
Outdated
Show resolved
Hide resolved
97461b6
to
dc491b2
Compare
dc491b2
to
aeaa60e
Compare
Description
Introduction of the
Toast
component. It's a composition of two subcomponents:Toast
ToastBar
(the message popup itself)Additional context
Safe area inset on iPhone:
Virtual keyboard interaction on Android:
The same on iPhone (not working):
Issue reference