Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce the Toast component #DS-1112 #1293

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

adamkudrna
Copy link
Contributor

Description

Introduction of the Toast component. It's a composition of two subcomponents:

  • Toast
  • ToastBar (the message popup itself)

Additional context

Safe area inset on iPhone:

Snímek obrazovky 2024-02-23 v 23 00 56 Snímek obrazovky 2024-02-23 v 23 01 17

Virtual keyboard interaction on Android:

Snímek obrazovky 2024-02-23 v 22 56 09

The same on iPhone (not working):

Snímek obrazovky 2024-02-23 v 22 59 56

Issue reference

@github-actions github-actions bot added the feature New feature or request label Feb 23, 2024
Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit aeaa60e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65e0a90fb33a7c0007434014

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit aeaa60e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65e0a90f35e1cd00088b7c8f

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit aeaa60e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65e0a90f482cf100097f4abe

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit aeaa60e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65e0a90f9105ef00087bf976

@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

coverage: 80.15%. remained the same
when pulling aeaa60e on feature/web-toast
into c30f353 on main.

@literat
Copy link
Collaborator

literat commented Feb 26, 2024

Inverted variant has no hover effect on dismiss button?

@adamkudrna
Copy link
Contributor Author

Inverted variant has no hover effect on dismiss button?

Just the border, not the background like in other button variants. Even the change of the border color is almost invisible. See https://spirit-design-system-demo.netlify.app/src/scss/components/button/.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing I noticed is that when I open the demo on any of my devices, the floating bars are over the static ones and it is a little bit hard to distinguish them. Maybe at least one of them could be in some emotion color? Also when I switch to top alignment on my phone, I am not able to switch back without reloading. :)

@crishpeen
Copy link
Member

Screenshot_20240226-151425.png

Btw 😬

@adamkudrna adamkudrna force-pushed the feature/web-toast branch 2 times, most recently from c98a39e to b1a3342 Compare February 27, 2024 14:56
@adamkudrna adamkudrna marked this pull request as ready for review February 27, 2024 15:05
@adamkudrna adamkudrna requested review from literat, pavelklibani and a team as code owners February 27, 2024 15:05
@adamkudrna
Copy link
Contributor Author

LGTM, one thing I noticed is that when I open the demo on any of my devices, the floating bars are over the static ones and it is a little bit hard to distinguish them. Maybe at least one of them could be in some emotion color?

I know. Like this maybe?

image

Also when I switch to top alignment on my phone, I am not able to switch back without reloading. :)

Try scrolling the page 🙂.

@adamkudrna adamkudrna changed the title Feat(web): Introduce Toast component #DS-1112 Feat(web): Introduce the Toast component #DS-1112 Feb 27, 2024
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You can prepare a talk about Toast for next meetup :))

packages/web/src/scss/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/index.html Outdated Show resolved Hide resolved
@adamkudrna adamkudrna added the run-visual-tests Runs visual regression testing on this PR label Feb 29, 2024
@adamkudrna adamkudrna merged commit 07742b8 into main Feb 29, 2024
23 of 24 checks passed
@adamkudrna adamkudrna deleted the feature/web-toast branch February 29, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants