Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(web-react): Web package is optional peer dependency #1288

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Chore(web-react): Web package is optional peer dependency #1288

merged 1 commit into from
Dec 17, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 20, 2024

Description

  • we cannot use web-react without web and icons package
  • it also tells lerna how to manage builds and in what order

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested review from pavelklibani and a team as code owners February 20, 2024 14:05
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Feb 20, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 2cf1b61
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65d4b1bcccbec100083ba374
😎 Deploy Preview https://deploy-preview-1288--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 2cf1b61
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65d4b1bc43967e00089bc8e0
😎 Deploy Preview https://deploy-preview-1288--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Status

coverage: 71.217% (-25.2%) from 96.371%
when pulling 2cf1b61 on chore/icon-web-dependency
into a78af4f on chore/DS-1162-sass-optional-dependency.

Base automatically changed from chore/DS-1162-sass-optional-dependency to main February 20, 2024 14:28
@literat literat requested review from adamkudrna and crishpeen March 4, 2024 14:22
@literat literat force-pushed the chore/icon-web-dependency branch from 2cf1b61 to 154ca20 Compare April 5, 2024 08:29
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c4cc100
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67614ee0b39f210008bce1d8
😎 Deploy Preview https://deploy-preview-1288--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit c4cc100
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67614ee09c2a1d0008555861

@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 154ca20
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/660fb658a1adc9000866c621

@literat literat changed the title Chore(web-react): Icon and web package are direct dependencies Chore(web-react): Web package is direct dependency Apr 5, 2024
@adamkudrna adamkudrna requested a review from curdaj as a code owner October 31, 2024 09:32
@literat literat force-pushed the chore/icon-web-dependency branch 3 times, most recently from 8e410b2 to 0dd0a17 Compare December 16, 2024 19:44
@literat literat changed the title Chore(web-react): Web package is direct dependency Chore(web-react): Web package is optional peer dependency Dec 16, 2024
@literat literat requested a review from crishpeen December 16, 2024 19:45
@literat literat force-pushed the chore/icon-web-dependency branch from 0dd0a17 to 45ea6c3 Compare December 17, 2024 08:45
@literat
Chore(web-react): Icon and web package are optional peer dependencies
c4cc100 
  * we can use web-react without web and icons package
  * the web-react package is technically unstyled, it uses class names only
  * however some kind of styling must be used, and in a same manner the icons must be used
  * icons are exported and generated from the supernova
  * web package is used as a base for styling, so install it
@literat literat force-pushed the chore/icon-web-dependency branch from 45ea6c3 to c4cc100 Compare December 17, 2024 10:13
@literat literat merged commit 557f3e5 into main Dec 17, 2024
23 checks passed
@literat literat deleted the chore/icon-web-dependency branch December 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@literat literat

Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@literat @adamkudrna @crishpeen