Skip to content

Commit

Permalink
Chore(web-react): Icon and web package are optional peer dependencies
Browse files Browse the repository at this point in the history
  * we can use web-react without web and icons package
  * the web-react package is technically unstyled, it uses class names only
  * however some kind of styling must be used, and in a same manner the icons must be used
  * icons are exported and generated from the supernova
  * web package is used as a base for styling, so install it
  • Loading branch information
literat committed Dec 17, 2024
1 parent 724b9ba commit 557f3e5
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 10 deletions.
17 changes: 12 additions & 5 deletions packages/web-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,18 @@
"webpack-merge": "6.0.1"
},
"peerDependencies": {
"@lmc-eu/spirit-design-tokens": "*",
"@lmc-eu/spirit-icons": "*",
"@lmc-eu/spirit-web": "*",
"react": "^17.0.2 || ^18.0.0",
"react-dom": "^17.0.2 || ^18.0.0"
"@lmc-eu/spirit-icons": "^2.0.0",
"@lmc-eu/spirit-web": "^3.0.0",
"react": "^17.0.2 || ^18.0.0 || ^19.0.0",
"react-dom": "^17.0.2 || ^18.0.0 || ^19.0.0"
},
"peerDependenciesMeta": {
"@lmc-eu/spirit-icons": {
"optional": true
},
"@lmc-eu/spirit-web": {
"optional": true
}
},
"scripts": {
"build:prepare": "shx rm -rf dist && shx mkdir -p dist && shx cp package.json README.md dist/ ",
Expand Down
14 changes: 9 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5119,11 +5119,15 @@ __metadata:
webpack-cli: "npm:5.1.4"
webpack-merge: "npm:6.0.1"
peerDependencies:
"@lmc-eu/spirit-design-tokens": "*"
"@lmc-eu/spirit-icons": "*"
"@lmc-eu/spirit-web": "*"
react: ^17.0.2 || ^18.0.0
react-dom: ^17.0.2 || ^18.0.0
"@lmc-eu/spirit-icons": ^2.0.0
"@lmc-eu/spirit-web": ^3.0.0
react: ^17.0.2 || ^18.0.0 || ^19.0.0
react-dom: ^17.0.2 || ^18.0.0 || ^19.0.0
peerDependenciesMeta:
"@lmc-eu/spirit-icons":
optional: true
"@lmc-eu/spirit-web":
optional: true
languageName: unknown
linkType: soft

Expand Down

0 comments on commit 557f3e5

Please sign in to comment.