Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/web-react: Make sass dependency optional peer dependency and fix web-react dependencies #1286

Merged
merged 1 commit into from
Feb 20, 2024
Merged

web/web-react: Make sass dependency optional peer dependency and fix web-react dependencies #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ in your HTML template:

### Advanced Implementation in Product with Sass

❗ **Important:** Make sure you have
[configured Sass load path][configuring-load-path] for `@tokens` and
❗ **Important:** Make sure you have `sass` dependency installed in your project (`sass` is marked as optional peer dependency since you can use the pre-built distribution CSS).
And also [configure Sass load path][configuring-load-path] for `@tokens` and
`node_modules` so all dependencies are resolved correctly by Sass.

Having the Sass load path configured, import just the components you need in
Expand Down
7 changes: 6 additions & 1 deletion packages/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@
"vite-plugin-handlebars": "1.6.0"
},
"peerDependencies": {
"sass": ">=1.57.0"
"sass": ">=1.57.0 < 2"
},
"peerDependenciesMeta": {
"sass": {
"optional": true
}
},
"nx": {
"targets": {
Expand Down
Loading