web/web-react: Make sass dependency optional peer dependency and fix web-react dependencies
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
pavelklibani,
a team,
adamkudrna and
crishpeen
as code owners
github-actions
bot
added
the
maintenance
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
changed the title
sass dependency optional peer dependencysass dependency optional peer dependency and fix web-react dependencies
✅ Deploy Preview for spirit-design-system-validations canceled.
|
pavelklibani
approved these changes
Feb 19, 2024
adamkudrna
reviewed
Feb 20, 2024
refs #DS-1162
literat
force-pushed
the
chore/DS-1162-sass-optional-dependency
branch
from
3a739ad to
a78af4f
Compare
pavelklibani
approved these changes
Feb 20, 2024
adamkudrna
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
sassas an optional peer dependency in the web package because there is no need to install it when you are using styles from CDN.https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta
Additional context
Icon and web package are direct dependencies
Issue reference
https://jira.almacareer.tech/browse/DS-1162
Before submitting the PR, please make sure you do the following
fixes #123).