Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing post mortems #1277

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Introducing post mortems #1277

merged 2 commits into from
Apr 11, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 13, 2024

Description

Add post mortem to the unnecessary logging of the Icon component.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1145


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested a review from a team as a code owner February 13, 2024 12:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 13, 2024
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 97db27e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6617cfd2916f7800085230e8

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 97db27e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6617cfd267c1cf00080c1608
😎 Deploy Preview https://deploy-preview-1277--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 25796f9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65cb7391b4d80000084461f3

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 25796f9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65cb739197fda900088ebe48

@coveralls
Copy link

coveralls commented Feb 13, 2024

Coverage Status

coverage: 81.009% (-15.4%) from 96.371%
when pulling 97db27e on docs/introduce-post-mortems
into 9b44190 on main.

docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/2024-02-05-deprecated-icon-rendering.md Outdated Show resolved Hide resolved
docs/postmortems/README.md Outdated Show resolved Hide resolved
docs/postmortems/2024-02-05-deprecated-icon-rendering.md Outdated Show resolved Hide resolved
docs/postmortems/2024-02-05-deprecated-icon-rendering.md Outdated Show resolved Hide resolved
@literat literat force-pushed the docs/introduce-post-mortems branch from 25796f9 to ab579ab Compare April 5, 2024 09:57
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 97db27e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6617cfd261c6b00008d35215
😎 Deploy Preview https://deploy-preview-1277--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat requested a review from crishpeen April 8, 2024 20:04
docs/postmortems/2024-02-05-deprecated-icon-rendering.md Outdated Show resolved Hide resolved
docs/postmortems/2024-02-05-deprecated-icon-rendering.md Outdated Show resolved Hide resolved
docs/postmortems/0000-00-00-template.md Outdated Show resolved Hide resolved
docs/postmortems/README.md Outdated Show resolved Hide resolved
docs/postmortems/README.md Outdated Show resolved Hide resolved
@literat literat force-pushed the docs/introduce-post-mortems branch from bb4c44e to 97db27e Compare April 11, 2024 11:56
@literat literat merged commit e8a7f73 into main Apr 11, 2024
28 checks passed
@literat literat deleted the docs/introduce-post-mortems branch April 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants