Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Removing Icon with dangerouslySetInnerHTML in favor of usage html-react-parser #1272

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 8, 2024

Description

Removing Icon with dangerouslySetInnerHTML in favor of usage html-react-parser. Which is required as a regular dependency.

Additional context

Introducing the documentation of this problem in the post-mortem template.

Issue reference

https://jira.almacareer.tech/browse/DS-1145

#1277


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 3fe1e62
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65cb5f704d98b500089a4fea

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 3fe1e62
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65cb5f704d98b500089a4fec

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 3fe1e62
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65cb5f700fd85f00087ab9bd

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 3fe1e62
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65cb5f70761e7100089586ae

@literat literat changed the title Fix/ds 1145 web react require html parser Fix(web-react): Removing Icon with dangerouslySetInnerHTML in favor of usage html-react-parser Feb 8, 2024
  * ensure that the Icon component will be working either on client and
    server
@literat literat force-pushed the fix/DS-1145-web-react-require-html-parser branch from 3225d8f to 41b5dbd Compare February 8, 2024 14:48
@literat literat marked this pull request as ready for review February 8, 2024 14:48
@literat literat requested review from pavelklibani and a team as code owners February 8, 2024 14:48
@coveralls
Copy link

coveralls commented Feb 8, 2024

Coverage Status

coverage: 72.818%. remained the same
when pulling 3fe1e62 on fix/DS-1145-web-react-require-html-parser
into b7c145f on main.

@literat literat force-pushed the fix/DS-1145-web-react-require-html-parser branch 2 times, most recently from 93f3b5d to 3fe1e62 Compare February 13, 2024 12:24
@literat literat merged commit 84ef862 into main Feb 14, 2024
20 checks passed
@literat literat deleted the fix/DS-1145-web-react-require-html-parser branch February 14, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants