-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web-react): Removing Icon with dangerouslySetInnerHTML in favor of usage html-react-parser #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
literat
changed the title
Fix/ds 1145 web react require html parser
Fix(web-react): Removing Icon with dangerouslySetInnerHTML in favor of usage html-react-parser
Feb 8, 2024
* ensure that the Icon component will be working either on client and server
literat
force-pushed
the
fix/DS-1145-web-react-require-html-parser
branch
from
February 8, 2024 14:48
3225d8f
to
41b5dbd
Compare
literat
commented
Feb 8, 2024
literat
commented
Feb 8, 2024
pavelklibani
approved these changes
Feb 12, 2024
literat
commented
Feb 13, 2024
crishpeen
reviewed
Feb 13, 2024
literat
force-pushed
the
fix/DS-1145-web-react-require-html-parser
branch
2 times, most recently
from
February 13, 2024 12:24
93f3b5d
to
3fe1e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing Icon with
dangerouslySetInnerHTML
in favor of usagehtml-react-parser
. Which is required as a regular dependency.Additional context
Introducing the documentation of this problem in the post-mortem template.
Issue reference
https://jira.almacareer.tech/browse/DS-1145
#1277
Before submitting the PR, please make sure you do the following
fixes #123
).