Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(web,web-react,web-twig): Introduce visual tests of all components #DS-660 #1196

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Test(web,web-react,web-twig): Introduce visual tests of all components #DS-660 #1196

merged 6 commits into from
Jan 30, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit a2d77a4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65b8c09083008800083860bc

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit a2d77a4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65b8c090410fa1000864ab07

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit a2d77a4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65b8c09089adf80008121319
😎 Deploy Preview https://deploy-preview-1196--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit a2d77a4
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65b8c0903397f90008804a63
😎 Deploy Preview https://deploy-preview-1196--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Coverage Status

coverage: 70.462%. remained the same
when pulling 25898cf on test/e2e-components
into 8acf2e7 on main.

@literat
Copy link
Collaborator

literat commented Jan 3, 2024

I believe that the snapshots are correct (do not see them all). Just wonder, how much bigger the repo is now? 🤔

@crishpeen crishpeen force-pushed the test/e2e-components branch from 25898cf to e9f2322 Compare January 4, 2024 11:53
@crishpeen crishpeen marked this pull request as ready for review January 4, 2024 11:59
@crishpeen crishpeen requested review from pavelklibani, a team and adamkudrna as code owners January 4, 2024 11:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Coverage Status

coverage: 70.462% (-6.8%) from 77.257%
when pulling e9f2322 on test/e2e-components
into 6e068c9 on main.

@crishpeen crishpeen force-pushed the test/e2e-components branch from e9f2322 to 02cb61b Compare January 11, 2024 16:19
@coveralls
Copy link

coveralls commented Jan 11, 2024 •
edited
Loading

Coverage Status

coverage: 80.578%. remained the same
when pulling a2d77a4 on test/e2e-components
into bba9fb3 on main.

@crishpeen crishpeen force-pushed the test/e2e-components branch from 02cb61b to 9c88fdd Compare January 16, 2024 09:11
@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR e2e labels Jan 16, 2024
@crishpeen crishpeen force-pushed the test/e2e-components branch from 9c88fdd to 18b2b92 Compare January 16, 2024 09:28
literat
literat approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

adamkudrna
adamkudrna reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first place, you've done a really great job! 👏🏻

I basically added a few notes on naming issues and a wish for documentation.

apps/web-twig-demo/public/index.php Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/layout/base.html.twig Outdated Show resolved Hide resolved
packages/web-react/config/vite/app.ts Show resolved Hide resolved
packages/web-react/src/components/FileUploader/demo/index.tsx Show resolved Hide resolved
packages/web-twig/src/Resources/components/Checkbox/Checkbox.stories.twig Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts Show resolved Hide resolved
@crishpeen crishpeen force-pushed the test/e2e-components branch from 18b2b92 to 4aff08f Compare January 22, 2024 23:35
@literat literat removed the e2e label Jan 23, 2024
@crishpeen crishpeen removed the run-visual-tests Runs visual regression testing on this PR label Jan 23, 2024
@crishpeen crishpeen force-pushed the test/e2e-components branch from 4aff08f to d4836ba Compare January 23, 2024 09:27
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Jan 23, 2024
@crishpeen crishpeen force-pushed the test/e2e-components branch from d4836ba to 0fda22d Compare January 23, 2024 10:13
@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR and removed run-visual-tests Runs visual regression testing on this PR labels Jan 23, 2024
adamkudrna
adamkudrna approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for the docs! All I have is basically fixing typos and formatting.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@crishpeen
Feat(demo): Add option to hide symfony toolbar using URL param
7b87c15
@crishpeen
Feat(demo,web,web-react,form-validations): Set font-display to block …
b1eea61 
…in google fonts load

We need to do this in order to block full render before the fonts are loaded.
If the page rendered and then the fonts swapped it caused errors in e2e tests.
@crishpeen
Chore(web,web-react): Hide Vite HMR overlay
dafeafd 
The errors are still shown in console.
We need to do this to avoid visual tests errors.
@crishpeen
Chore(web,web-twig,web-react): Unify demo differences in components #…
e13077d 
…DS-660
@crishpeen
Feat(common): Configure https in server constants
5c643e4
@crishpeen
Test(web,web-react,web-twig): Introduce visual tests of all component…
a2d77a4 
…s #DS-660
@crishpeen crishpeen force-pushed the test/e2e-components branch from 0fda22d to a2d77a4 Compare January 30, 2024 09:25
@crishpeen crishpeen merged commit 4600d4b into main Jan 30, 2024
35 checks passed
@crishpeen crishpeen deleted the test/e2e-components branch January 30, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@crishpeen crishpeen

Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @literat @coveralls @adamkudrna