Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-twig): Do not render class in the style attribute of the GridItem #1166

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix(web-twig): Do not render class in the style attribute of the GridItem #1166

merged 2 commits into from
Nov 30, 2023

Conversation

dlouhak
Copy link
Contributor

@dlouhak dlouhak commented Nov 27, 2023 •
edited
Loading

Small bug fix. Currently it is class even passed to the style attribute.

❌ Current HTML output:

<div class="GridItem d-tablet-none" style="--grid-item-column-start: 1;display-tablet-none">

✅ Fixed HTML output:

<div class="GridItem d-tablet-none" style="--grid-item-column-start: 1;">

@dlouhak dlouhak added the bug Something isn't working label Nov 27, 2023
@dlouhak dlouhak self-assigned this Nov 27, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5ba282a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/656851569ef6930008627760

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 5ba282a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65685156b977b600076f8d22

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 5ba282a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65685156e249ff0008e780dd

@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 5ba282a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/656851562d94f000082e59f5

literat
literat approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crishpeen crishpeen force-pushed the fix/grid-item-style-attribute branch from 7e7f068 to 5ba282a Compare November 30, 2023 09:09
@github-actions GitHub Actions
Copy link
Contributor

Coverage Status

coverage: 96.46% (+15.9%) from 80.594%
when pulling 5ba282a on fix/grid-item-style-attribute
into 4307f68 on main.

@crishpeen crishpeen merged commit 4adbc16 into main Nov 30, 2023
35 checks passed
@crishpeen crishpeen deleted the fix/grid-item-style-attribute branch November 30, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@dlouhak dlouhak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlouhak @literat @crishpeen @pavelklibani