Fix(web-twig): Do not render class in the style attribute of the `Mod…

…alDialog`
lmc-eu · Nov 30, 2023 · 4adbc16 · 4adbc16
1 parent 38bcd4e
commit 4adbc16
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/web-twig/src/Resources/components/Modal/ModalDialog.twig b/packages/web-twig/src/Resources/components/Modal/ModalDialog.twig
@@ -37,7 +37,7 @@
 {%- endif -%}
 
 {# Attributes #}
-{%- set _styleAttr = _style or (_styleProps.style is not same as(null)) ? 'style="' ~ _style ~ _styleProps | join() ~ '"' -%}
+{%- set _styleAttr = _style or (_styleProps.style is not same as(null)) ? 'style="' ~ _style ~ _styleProps.style | join() ~ '"' -%}
 
 <{{ _elementType }}
     {{ mainProps(props, _allowedAttributes) }}

diff --git a/packages/web-twig/src/Resources/components/Modal/__tests__/__fixtures__/modalDefault.twig b/packages/web-twig/src/Resources/components/Modal/__tests__/__fixtures__/modalDefault.twig
@@ -46,6 +46,7 @@
         method="dialog"
         preferredHeightOnMobile="400px"
         preferredHeightFromTabletUp="500px"
+        UNSAFE_className="custom-class"
         UNSAFE_style="outline: 5px solid blue; outline-offset: -5px;"
     >
         <ModalHeader

diff --git a/...b-twig/src/Resources/components/Modal/__tests__/__snapshots__/modalDefault.twig.snap.html b/...b-twig/src/Resources/components/Modal/__tests__/__snapshots__/modalDefault.twig.snap.html
@@ -59,7 +59,7 @@ <h2 class="ModalHeader__title" id="modal-example-title">
     <!-- Render with all props -->
 
     <dialog class="Modal" id="modal-example-2" aria-labelledby="modal-example-2-title">
-      <form autocomplete="on" method="dialog" class="ModalDialog" style="--modal-max-height-tablet: 700px;--modal-preferred-height-mobile: 400px;--modal-preferred-height-tablet: 500px;outline: 5px solid blue; outline-offset: -5px;">
+      <form autocomplete="on" method="dialog" class="ModalDialog custom-class" style="--modal-max-height-tablet: 700px;--modal-preferred-height-mobile: 400px;--modal-preferred-height-tablet: 500px;outline: 5px solid blue; outline-offset: -5px;">
         <header class="ModalHeader">
           <h2 class="ModalHeader__title" id="modal-example-2-title">
             Title of the Modal