Fix(web): Refactor Accordion styles to fully support theming via design tokens #DS-1074
#1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamkudrna
force-pushed
the
fix/accordion-theming
branch
2 times, most recently
from
72231ed to
f137966
Compare
✅ Deploy Preview for spirit-design-system-validations canceled.
|
4 tasks
literat
approved these changes
Nov 22, 2023
pavelklibani
approved these changes
Nov 23, 2023
…sign tokens #DS-1074 * Header background is now always on the same element so nothing gets overlapped when colors change. * Stacking of header elements has been slightly refactored while retaining the intended behavior. * Component styles have been thoroughly documented so next time we don't have to spend a day on it.
adamkudrna
force-pushed
the
fix/accordion-theming
branch
from
008d5eb to
9106d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lmc.cz/browse/DS-1074
This PR replaces PR #1157.