Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web): Fix Accordion item active overlay z-index #DS-1074 #1157

Closed
wants to merge 1 commit into from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 8c6abe7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/655638685c2c37000881db6d

@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2023
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 8c6abe7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/655638687d2f6b0008bd7088

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 8c6abe7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/655638687d90ac0008bb4c4f
😎 Deploy Preview https://deploy-preview-1157--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 8c6abe7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/655638684fd7bf0008cee811

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamkudrna
Copy link
Contributor

Closing in favour of a more robust solution #1162.

(In this PR, header background is not retained when an interactive slot item is hovered.)

@adamkudrna adamkudrna closed this Nov 21, 2023
@adamkudrna adamkudrna deleted the fix/accordion-active-overlay-z-index branch November 21, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants