Fix(web-react): Removing unused prop #DS-933 #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 43634db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
pavelklibani
force-pushed
the
fix/DS-933-fileuploader-isdisabled-type
branch
from
0a3cef6 to
650b1d1
Compare
|
Can you please change the commit message to I will be more than happy if in the commit message will be the name of the component, which is affected by the change. Thanks :-) |
literat
approved these changes
Oct 23, 2023
|
I have successfully ✅ restarted those two failed deploys: |
- unused prop `isDisabled` was removed from FileUploader component #DS-933
pavelklibani
force-pushed
the
fix/DS-933-fileuploader-isdisabled-type
branch
from
650b1d1 to
43634db
Compare
Commit message changed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isDisabledwas removed fromFileUploadercomponentisDisabledis still usable inFileUploaderInputcomponentIssue reference
web-react: FileUploader má prop isDisabled, co nic nedělá