Fix(web-react): Removing unused prop #DS-933

- unused prop `isDisabled` was removed from FileUploader component
lmc-eu · Oct 23, 2023 · 0a3cef6 · 0a3cef6
1 parent 0cb30d5
commit 0a3cef6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/packages/web-react/src/components/FileUploader/FileUploader.tsx b/packages/web-react/src/components/FileUploader/FileUploader.tsx
@@ -13,16 +13,16 @@ import {
 
 const FileUploader = (props: SpiritFileUploaderProps) => {
   const {
-    children,
-    id,
-    fileQueue,
-    onDismiss,
     addToQueue,
+    children,
     clearQueue,
-    findInQueue,
-    updateQueue,
     errorMessages,
+    fileQueue,
+    findInQueue,
+    id,
     isFluid,
+    onDismiss,
+    updateQueue,
     ...restProps
   } = props;
 

diff --git a/packages/web-react/src/components/FileUploader/FileUploaderInput.tsx b/packages/web-react/src/components/FileUploader/FileUploaderInput.tsx
@@ -17,9 +17,8 @@ const FileUploaderInput = (props: SpiritFileUploaderInputProps) => {
     iconName = 'upload',
     id,
     inputRef,
-    isLabelHidden,
     isDisabled,
-    queueLimitBehavior = 'none',
+    isLabelHidden,
     isMultiple,
     isRequired,
     label,
@@ -28,6 +27,7 @@ const FileUploaderInput = (props: SpiritFileUploaderInputProps) => {
     maxFileSize = DEFAULT_FILE_SIZE_LIMIT,
     maxUploadedFiles = DEFAULT_FILE_QUEUE_LIMIT,
     onError,
+    queueLimitBehavior = 'none',
     validationState,
     validationText,
     ...restProps
@@ -40,25 +40,25 @@ const FileUploaderInput = (props: SpiritFileUploaderInputProps) => {
     isDragging,
     isDropZoneHidden,
     onChange,
-    onDragOver,
     onDragEnter,
     onDragLeave,
+    onDragOver,
     onDrop,
   } = useFileUploaderInput({
     accept,
+    isMultiple,
     maxFileSize,
     maxUploadedFiles,
-    isMultiple,
-    queueLimitBehavior,
     onError,
+    queueLimitBehavior,
   });
   const { classProps } = useFileUploaderStyleProps({
-    isDragAndDropSupported,
-    isLabelHidden,
     isDisabled,
-    isDropZoneHidden,
-    isDragging,
     isDisabledByQueueLimitBehavior,
+    isDragAndDropSupported,
+    isDragging,
+    isDropZoneHidden,
+    isLabelHidden,
     isRequired,
     queueLimitBehavior,
     validationState,

diff --git a/packages/web-react/src/components/FileUploader/README.md b/packages/web-react/src/components/FileUploader/README.md
@@ -354,7 +354,6 @@ const customUpdate = (_event: MouseEvent, file: File) => {
 | `fileQueue`                           | `FileQueueMapType`                                                   | —       | ✔        | Queue of items to upload                                            |
 | `findInQueue`                         | `(key: string) => FileQueueMapType`                                  | —       | ✔        | A callback to find a particular item in the queue                   |
 | `id`                                  | `string`                                                             | —       | ✔        | FileUploader id                                                     |
-| `isDisabled`                          | `bool`                                                               | —       | ✕        | When the field is supposed to be disabled                           |
 | `isFluid`                             | `bool`                                                               | —       | ✕        | When the field is supposed to be fluid                              |
 | `onDismiss`                           | `(key: string) => FileQueueMapType`                                  | —       | ✔        | A callback to delete a particular item from the queue               |
 | `UNSAFE_className`                    | `string`                                                             | —       | ✕        | FileUploader custom class name                                      |

diff --git a/packages/web-react/src/types/fileUploader.ts b/packages/web-react/src/types/fileUploader.ts
@@ -108,7 +108,6 @@ export interface FileUploaderAttachmentBaseProps extends Omit<SpiritLItemElement
 
 export interface FileUploaderBaseProps extends SpiritDivElementProps, Partial<FileUploaderErrorMessagesProps> {
   id: string;
-  isDisabled?: boolean;
   isFluid?: boolean;
 }