-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prot warriors cast vigilance when in a group #825
Merged
hermensbas
merged 33 commits into
liyunfan1223:master
from
avirar:warrior_prot_vigilance
Dec 29, 2024
Merged
Prot warriors cast vigilance when in a group #825
hermensbas
merged 33 commits into
liyunfan1223:master
from
avirar:warrior_prot_vigilance
Dec 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for existence of Vigilance in raid already
Check for existence of Vigilance in raid already Apply to tanks, then highest gearscore DPS.
Bots keep assigning it to me and not maintank? Added logging to clarify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prot warriors will cast vigilance as part of their tank strategy. This allows their taunt spell cooldown to reset frequently as well as the other benefits of vigilance. Since its part of their combat strategy they will only assign it once engaged in combat.
Bots will not assign vigilance to themselves or dead group members, otherwise the priority of vigilance targets is:
Bots will reassign it when the priority target changes, e.g death, tank reassignment.