Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eligible bots cast Greater blessings for Might, Kings and Wisdom when in groups #820

Closed
wants to merge 2 commits into from

Conversation

nl-saw
Copy link
Contributor

@nl-saw nl-saw commented Dec 26, 2024

This will make eligible bots (when on or above the proper level) cast Greater blessings for Might, Kings and Wisdom.

Looking for testers and feedback.

@noisiver
Copy link
Collaborator

noisiver commented Dec 27, 2024

I don't think the best solution is to swap minor for greater blessing as-is.

Just look at Paladin. Protection wants sanctuary, holy wants wisdom and retribution wants might/kings.

I think Ideally there should be some logic to determine if there are multiple characters of the same class in the group that need different blessings before choosing greater blessing.

No matter what: Thank you for your contributions!

@nl-saw
Copy link
Contributor Author

nl-saw commented Dec 27, 2024

I don't think the best solution is to swap minor for greater blessing as-is.

Just look at Paladin. Protection wants sanctuary, holy wants wisdom and retribution wants might/kings.

I think Ideally there should be some logic to determine if there are multiple characters of the same class in the group that need different blessings before choosing greater blessing.

No matter what: Thank you for your contributions!

I surely agree that would be best. Unfortunately -but, correct me if I'm wrong- they currently do not bless sanctuary at all when in groups. At least I haven't seen them doing that on tanks currently even with 7+ pally's in the group. It is something I'd like to take a look at later on, so for now the current improvement is that instead of blessing these 3 individually, its covered with the greater variance, when possible. A human player can still bless the sanctuary or have a bot bless a sanctuary on tanks manually. If I am not wrong about it then 'fixing' sanctuary could be a good step 2.

@noisiver
Copy link
Collaborator

For the time being replacing minor with greater blessing works fine. It's just something to add to in the future, some kind of logic there.

They do not use Sanctuary at all, you are correct.

@nl-saw
Copy link
Contributor Author

nl-saw commented Dec 27, 2024

Thank you for confirming that it's not something only on my end :)

There is definitely room for improvement in that respect.

@nl-saw
Copy link
Contributor Author

nl-saw commented Dec 27, 2024

I'm not satisfied yet, this needs some more attention.

@nl-saw nl-saw closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants