Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics for fallback jobs #854

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix metrics for fallback jobs #854

merged 1 commit into from
Sep 12, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 8, 2023

Since we're re-using the job object now we need to save to the db in the foreground go-routine to avoid picking up values from the fallback job

@mjh1 mjh1 requested a review from thomshutt September 8, 2023 10:44
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #854 (aa42440) into main (c81f282) will not change coverage.
The diff coverage is 100.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #854   +/-   ##
=============================================
  Coverage   51.66228%   51.66228%           
=============================================
  Files             63          63           
  Lines           6076        6076           
=============================================
  Hits            3139        3139           
  Misses          2685        2685           
  Partials         252         252           
Files Changed Coverage Δ
pipeline/coordinator.go 80.61466% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81f282...aa42440. Read the comment docs.

Files Changed Coverage Δ
pipeline/coordinator.go 80.61466% <100.00000%> (ø)

@thomshutt
Copy link
Contributor

LGTM but linting isn't happy

@mjh1 mjh1 changed the title Pass job info by value to fix metrics for fallback jobs Fix metrics for fallback jobs Sep 12, 2023
@mjh1 mjh1 requested a review from thomshutt September 12, 2023 09:28
@mjh1 mjh1 merged commit 7fc5223 into main Sep 12, 2023
12 checks passed
@mjh1 mjh1 deleted the mh/db-metrics branch September 12, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants