Pass job info by value to fix metrics for fallback jobs

Since we're re-using the job object now we need to pass by value here to avoid picking up values from the fallback job
livepeer · Sep 8, 2023 · 731b460 · 731b460
1 parent a363ab6
commit 731b460
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pipeline/coordinator.go b/pipeline/coordinator.go
@@ -556,7 +556,7 @@ func (c *Coordinator) finishJob(job *JobInfo, out *HandlerOutput, err error) {
 		WithLabelValues(labels...).
 		Add(float64(job.transcodedSegments))
 
-	go c.sendDBMetrics(job, out)
+	go c.sendDBMetrics(*job, getProfileCount(out))
 
 	job.result <- success
 }
@@ -568,7 +568,7 @@ func getProfileCount(out *HandlerOutput) int {
 	return len(out.Result.Outputs[0].Videos)
 }
 
-func (c *Coordinator) sendDBMetrics(job *JobInfo, out *HandlerOutput) {
+func (c *Coordinator) sendDBMetrics(job JobInfo, profileCount int) {
 	if c.MetricsDB == nil {
 		return
 	}
@@ -618,7 +618,7 @@ func (c *Coordinator) sendDBMetrics(job *JobInfo, out *HandlerOutput) {
 		job.pipeline,
 		job.catalystRegion,
 		job.state,
-		getProfileCount(out),
+		profileCount,
 		time.Since(job.startTime).Milliseconds(),
 		job.sourceSegments,
 		job.transcodedSegments,