Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manifest location to egress info #862

Merged
merged 6 commits into from
Oct 17, 2024
Merged

add manifest location to egress info #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
523ad86
add manifest_url to egress info
frostbyte73 Oct 17, 2024
e4a3e3d
generated protobuf
github-actions[bot] Oct 17, 2024
fa5eb31
location and presigned url
frostbyte73 Oct 17, 2024
37b555f
generated protobuf
github-actions[bot] Oct 17, 2024
049daa0
add internal cloud_backup_enabled option
frostbyte73 Oct 17, 2024
c5a5eaa
generated protobuf
github-actions[bot] Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-scissors-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"github.com/livekit/protocol": patch
---

added manifest details to egress info
401 changes: 212 additions & 189 deletions livekit/livekit_egress.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

379 changes: 191 additions & 188 deletions livekit/livekit_egress.twirp.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions protobufs/livekit_egress.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,9 @@ message EgressInfo {
repeated FileInfo file_results = 16;
repeated SegmentsInfo segment_results = 17;
repeated ImagesInfo image_results = 20;

// next ID: 23
string manifest_location = 23;
string manifest_presigned_url = 24;
// next ID: 24
}

message StreamInfoList {
Expand Down
2 changes: 2 additions & 0 deletions protobufs/rpc/egress.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ message StartEgressRequest {
string room_id = 3;
string token = 8;
string ws_url = 9;

bool cloud_backup_enabled = 10; // cloud only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok with cloud only concepts leaking into the TWIRP apis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done it in a few other places, like with egress clusterID, SIP KRISP_ENABLED, and even projectID in some internal SIP requests. We could put it in request metadata instead if you're strongly opposed, but I think this is a bit cleaner

}

message ListActiveEgressRequest {}
Expand Down
81 changes: 46 additions & 35 deletions rpc/egress.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 33 additions & 31 deletions rpc/egress.psrpc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.