add manifest location to egress info #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c5a5eaa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
frostbyte73
changed the title
| @@ -58,6 +58,8 @@ message StartEgressRequest { | |||
| string room_id = 3; | |||
| string token = 8; | |||
| string ws_url = 9; | |||
|
|
|||
| bool cloud_backup_enabled = 10; // cloud only | |||
There was a problem hiding this comment.
Are we ok with cloud only concepts leaking into the TWIRP apis?
There was a problem hiding this comment.
We've done it in a few other places, like with egress clusterID, SIP KRISP_ENABLED, and even projectID in some internal SIP requests. We could put it in request metadata instead if you're strongly opposed, but I think this is a bit cleaner
biglittlebigben
approved these changes
Oct 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.