Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types export for CJS and build config #359

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Fix types export for CJS and build config #359

merged 7 commits into from
Dec 16, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 11, 2024

closes #357

@lukasIO lukasIO requested a review from nbsp December 11, 2024 22:56
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: b45ad31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
livekit-server-sdk Patch
@livekit/rtc-node Patch
agent-dispatch Patch
@livekit/rtc-node-darwin-arm64 Patch
@livekit/rtc-node-darwin-x64 Patch
@livekit/rtc-node-linux-arm64-gnu Patch
@livekit/rtc-node-linux-x64-gnu Patch
@livekit/rtc-node-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Philzen
Copy link
Contributor

Philzen commented Dec 11, 2024

@lukasIO just to confirm i have checked out your fix branch and referenced it from my project – this definitely fixes #357 🚀

Cheers!

@lukasIO lukasIO requested review from davidzhao and bcherry December 16, 2024 13:06
.changeset/stupid-monkeys-invent.md Show resolved Hide resolved
@lukasIO lukasIO merged commit 628b9fd into main Dec 16, 2024
13 checks passed
@lukasIO lukasIO deleted the lukas/fix-pub-spec branch December 16, 2024 13:50
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ESM-style imports from livekit-server-sdk gives warnings ("current file is a CommonJS module")
3 participants