You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to generate the required .d.cts using tsup or tsc went over the top of my head, however npx publint advised that it would suffice to duplicate the .d.ts file for that (see commit message of b5d562a for a detailed explanation).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This is supposed to work according to `npx publint`:
> 1. pkg.exports["."].require types is not exported. Consider adding
> pkg.exports["."].require.types to be compatible with TypeScript's
> "moduleResolution": "bundler" compiler option. Note that you cannot
> use "./dist/index.d.ts" because it has a mismatching format. Instead,
> you can duplicate the file and use the .cts extension,
> e.g. pkg.exports["."].require.types: "./dist/index.d.cts"
thanks for this, I didn't see it and opened #359 which uses tsup directly to generate these, so we don't have to manually copy the files around. Thanks for raising the issue and offering a fix!
opened #359 which uses tsup directly to generate these, so we don't have to manually copy the files around.
That's of course the way (and feels much more trustworthy meaning less hacky). So at least i learned what i was looking for was hidden behind the dts: true option all along 😉
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Philzen
force-pushed
the
fix-publint-esm-cjs-mask
branch
from
May fix #357
How to generate the required
.d.ctsusing tsup or tsc went over the top of my head, howevernpx publintadvised that it would suffice to duplicate the.d.tsfile for that (see commit message of b5d562a for a detailed explanation).