Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saveUsername and make PreJoin backwards compatible #695

Merged
merged 14 commits into from
Nov 8, 2023

Conversation

Ocupe
Copy link
Contributor

@Ocupe Ocupe commented Nov 7, 2023

This pull request adds a new function, saveUsername, to the usePersistentUserChoices hook. This function allows the user's chosen username to be saved to persistent storage.

For backward compatibility and simplicity, the properties of the UserChoices type have been updated to match the original LocalUserChoices type. To avoid TS-hell The goal now is to deprecate the e2ee and sharedPassphrase properties before changing the type to UserChoices.

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: 6489844

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2023

size-limit report 📦

Path Size
LiveKitRoom only 2.06 KB (+10.53% 🔺)
LiveKitRoom with VideoConference 31.25 KB (+0.32% 🔺)
All exports 36.63 KB (+0.22% 🔺)

@Ocupe Ocupe requested a review from lukasIO November 7, 2023 14:27
@Ocupe Ocupe changed the title Add saveUsername function to usePersistentUserChoices hook Add saveUsername and make PreJoin backwards compatible Nov 7, 2023
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ocupe Ocupe merged commit c369bba into main Nov 8, 2023
2 checks passed
@Ocupe Ocupe deleted the persistent-username branch November 8, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants