-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saveUsername and make PreJoin backwards compatible #695
Conversation
usePersistentUserChoices hook
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This pull request adds a new function,
saveUsername
, to theusePersistentUserChoices
hook. This function allows the user's chosen username to be saved to persistent storage.For backward compatibility and simplicity, the properties of the UserChoices type have been updated to match the original LocalUserChoices type. To avoid TS-hell The goal now is to deprecate the
e2ee
andsharedPassphrase
properties before changing the type toUserChoices
.