Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save user choices to localstorage #135

Closed
wants to merge 4 commits into from

Conversation

Ocupe
Copy link
Contributor

@Ocupe Ocupe commented Oct 20, 2023

This PR adds the ability to save settings such as preferred video/audio device, username, and whether to join a room directly without the prejoin step.

I added a toggle to automatically join the next time:
image

To disable auto-join, I added this button, which only appears when auto-join is enabled:
image

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 2:35pm

Copy link
Collaborator

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg.

const LOCAL_STORAGE_KEY = 'livekit_meet';

type LocalStorageData = {
userChoices: LocalUserChoices;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better or worse (arguably worse) the e2ee pw is part of the LocalUserChoices. I don't think we should store that in local storage. also the setting whether or not e2ee is enabled doesn't really belong there and would be different from meeting to meeting.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... we gotta get e2ee outta there..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe hold this PR until that is done? otherwise it seems like things could get really confusing real fast.

@Ocupe Ocupe marked this pull request as draft November 17, 2023 19:27
@lukasIO
Copy link
Contributor

lukasIO commented Nov 22, 2023

superseded by livekit/components-js#695

@lukasIO lukasIO closed this Nov 22, 2023
@Ocupe
Copy link
Contributor Author

Ocupe commented Nov 23, 2023

superseded by livekit/components-js#695

Only partially. Autojoin not yet implemented. Let's keep the branch for now.

@lukasIO
Copy link
Contributor

lukasIO commented Nov 23, 2023

oh, sorry

@davidzhao davidzhao deleted the save-pre-join-choices-in-local-storage branch November 29, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants