-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save user choices to localstorage #135
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg.
const LOCAL_STORAGE_KEY = 'livekit_meet'; | ||
|
||
type LocalStorageData = { | ||
userChoices: LocalUserChoices; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better or worse (arguably worse) the e2ee pw is part of the LocalUserChoices
. I don't think we should store that in local storage. also the setting whether or not e2ee
is enabled doesn't really belong there and would be different from meeting to meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... we gotta get e2ee outta there..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe hold this PR until that is done? otherwise it seems like things could get really confusing real fast.
superseded by livekit/components-js#695 |
Only partially. Autojoin not yet implemented. Let's keep the branch for now. |
oh, sorry |
This PR adds the ability to save settings such as preferred video/audio device, username, and whether to join a room directly without the prejoin step.
I added a toggle to automatically join the next time:
To disable auto-join, I added this button, which only appears when auto-join is enabled: