AVAudioEngine version #526
Conversation
| private func _asyncConfigure(newState: State, oldState: State) async throws { | ||
| try await _configureRunner.run { | ||
| self.log("\(oldState) -> \(newState)") | ||
| let configureFunc = newState.customConfigureFunc ?? self.defaultConfigureAudioSessionFunc |
There was a problem hiding this comment.
make sure you also remove the customConfigureFunc property, and it seems like this will need to be a breaking change so we'll want to ensure this release goes out as 2.1.x and includes notes about this change
There was a problem hiding this comment.
Yes this is not intended to merge "as-is", I'll need to figure out backward compatibility.
The track counting approach was not a good idea. Instead this version gets direct callback from the audio device module, that session configuration is required.
| config.categoryOptions = [.allowBluetooth, .allowBluetoothA2DP, .allowAirPlay] | ||
| config.mode = AVAudioSession.Mode.videoChat.rawValue |
There was a problem hiding this comment.
my 2c: it might be worth allowing end-users to customize these options. our current setup requires .defaultToSpeaker. We also did not allow airplay specifically because of issues with noise cancellation.
(THANK YOU for going down the AVAudioEngine rabbit hole. I know it's a huge one)
There was a problem hiding this comment.
Yes, I will allow devs to customize the session. 🙂
Uses lib with : webrtc-sdk/webrtc#158
Needs more testing with devices, please don't ship.
TODO