Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo cancellation does not work as expected #527

Open
leson1106 opened this issue Dec 10, 2024 · 1 comment
Open

Echo cancellation does not work as expected #527

leson1106 opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@leson1106
Copy link

Describe the bug
Echo Cancellation did not work even if I enable all these properties for Room and LocalParticipant. This led to duplicate message as shown below, because Audio Engine often take output voice as the input as well.

Related thread on Slack.

try await liveKitRoom.connect(
    url: url,
    token: token,
    connectOptions: ConnectOptions(
        reconnectAttempts     : 1000,
        reconnectAttemptDelay : 3
    ),
    roomOptions: RoomOptions(
        defaultAudioCaptureOptions: .init(
            echoCancellation: true,
            noiseSuppression: true,
            autoGainControl: true,
            typingNoiseDetection: true,
            highpassFilter: true
        )
    )
)
try await localParticipant.setMicrophone(
    enabled: true,
    captureOptions: .init(
        echoCancellation: true,
        noiseSuppression: true,
        autoGainControl: true,
        typingNoiseDetection: true,
        highpassFilter: true
    )
)

SDK Version
2.0.14 and also upgraded to the latest version but no luck

iOS/macOS Version
iOS 18.1 and iOS 17.5

Xcode Version
Xcode 15.4.0 and Xcode 16.0.0

Steps to Reproduce
It's quite easy to reproduce just by creating a room, enable localParticipant microphone, and then start talking to each other.

Expected behavior
The transcriptions that received from delegate need to be filtered by echo cancellation somehow.

func room(_:participant:trackPublication:didReceiveTranscriptionSegments:)

Screenshots
ezgif-5-005d16fab7

@leson1106 leson1106 added the bug Something isn't working label Dec 10, 2024
@hiroshihorie
Copy link
Member

Hi, working on an AVAudioEngine version which hope fully does better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants