Fixed memory leak - LeakCanary leak detection io.livekit.android.rend… #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erer.TextureViewRenderer
|
@davidliu I'm thinking if it could not be issue of random crashes on peerConnection dispose as looks like it had references to tracks and some native memory may leak which could case that something wanted to access peerconneection which was not in memory anymore |
davidliu
reviewed
Nov 23, 2023
| view?.release() | ||
| view?.let { | ||
| it.release() | ||
| videoTrack?.removeRenderer(it) |
There was a problem hiding this comment.
Hmm, is the cleanupVideoTrack() not getting called for you? That's essentially what this is doing, so it seems redundant since should be called in the previous onDispose on line 80.
There was a problem hiding this comment.
I'll test more. But only after these changes I stopped getting leak notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes when my app leaves a call, LeakCanary shows that memory leak is detected. After these changes I stopped seeing this message
This PR should fix #324 issue