Use NumRings instead of separate Ring/Ring2 #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates libwacom_has_ring() and libwacom_has_ring2() for the new libwacom_get_num_rings(). In our tablet files we also remove Ring=true/Ring2=true and replace that with NumRings=. This makes the support line up better with strip support and removes some of the confusion in the tablet file where we have two independent Ring and Ring2 entries with different meanings.
|
@JoseExposito sorry, this will probably conflict with #659 |
whot
added a commit
to whot/libwacom
that referenced
this pull request
Oct 8, 2024
Fixes: 5b3a3a8 ("Use NumRings instead of separate Ring/Ring2 (linuxwacom#669)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates libwacom_has_ring() and libwacom_has_ring2() for the new libwacom_get_num_rings(). In our tablet files we also remove Ring=true/Ring2=true and replace that with NumRings=.
This makes the support line up better with strip support and removes some of the confusion in the tablet file where we have two independent Ring and Ring2 entries with different meanings.
Closes #668 #667