Skip to content

Commit

Permalink
Use NumRings instead of separate Ring/Ring2 (#669)
Browse files Browse the repository at this point in the history
This deprecates libwacom_has_ring() and libwacom_has_ring2() for the
new libwacom_get_num_rings(). In our tablet files we also remove
Ring=true/Ring2=true and replace that with NumRings=.

This makes the support line up better with strip support and removes
some of the confusion in the tablet file where we have two independent
Ring and Ring2 entries with different meanings.
  • Loading branch information
whot authored May 2, 2024
1 parent 03a9a24 commit 5b3a3a8
Show file tree
Hide file tree
Showing 99 changed files with 130 additions and 141 deletions.
2 changes: 1 addition & 1 deletion data/bamboo-0fg-m-p-alt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Layout=bamboo-0fg-s-p-alt.svg
Stylus=true
Reversible=false
Touch=false
Ring=true
NumRings=1

[Buttons]
Top=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/bamboo-0fg-s-p-alt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Layout=bamboo-0fg-s-p-alt.svg
Stylus=true
Reversible=false
Touch=false
Ring=true
NumRings=1

[Buttons]
Top=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/bamboo-0fg-s-p.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Layout=bamboo-0fg-s-p.svg
Stylus=true
Reversible=false
Touch=false
Ring=true
NumRings=1

[Buttons]
Top=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/bamboo-one.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ IntegratedIn=
Reversible=true
Stylus=true
Touch=false
Ring=false
NumRings=0
NumStrips=0
2 changes: 1 addition & 1 deletion data/cintiq-13hd.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0

[Buttons]
Left=B;C;G;H;A;F;I;D;E
2 changes: 1 addition & 1 deletion data/cintiq-13hdt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=B;C;G;H;A;F;I;D;E
2 changes: 1 addition & 1 deletion data/cintiq-16-2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-16.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-21ux2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ IntegratedIn=Display

[Features]
Stylus=true
Ring=false
NumRings=0
NumStrips=2
StatusLEDs=Touchstrip2;Touchstrip

Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-22.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-22hd.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
NumStrips=2

[Buttons]
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-22hdt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
NumStrips=2

[Buttons]
Expand Down
3 changes: 1 addition & 2 deletions data/cintiq-24hd-touch.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=true
Ring2=true
NumRings=2
StatusLEDs=Ring2;Ring

[Buttons]
Expand Down
3 changes: 1 addition & 2 deletions data/cintiq-24hd.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=true
Ring2=true
NumRings=2
StatusLEDs=Ring2;Ring

[Buttons]
Expand Down
3 changes: 1 addition & 2 deletions data/cintiq-27hd.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
3 changes: 1 addition & 2 deletions data/cintiq-27hdt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
Ring2=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-companion-2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ IntegratedIn=Display;System
[Features]
Stylus=true
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=A;B;C;D;E;F;G;H;I;J;K
2 changes: 1 addition & 1 deletion data/cintiq-companion-hybrid.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=B;C;G;H;A;F;I;D;E
2 changes: 1 addition & 1 deletion data/cintiq-companion.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ IntegratedIn=Display;System
[Features]
Stylus=true
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=B;C;G;H;A;F;I;D;E
2 changes: 1 addition & 1 deletion data/cintiq-pro-13.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Keys]
# first key is in-kernel display toggle
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-pro-16-2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-pro-16.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-pro-17.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-pro-22.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-pro-24-p.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-pro-24-pt.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/cintiq-pro-27.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0

[Buttons]
Left=A;B;C;D
Expand Down
2 changes: 1 addition & 1 deletion data/cintiq-pro-32.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/dell-canvas-27.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/dtc-121.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
3 changes: 1 addition & 2 deletions data/dth-1152.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
Ring2=false
NumRings=0
NumStrips=0
2 changes: 1 addition & 1 deletion data/dth-134.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
NumRings=0
3 changes: 1 addition & 2 deletions data/dth-2242.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
Ring2=false
NumRings=0
NumStrips=0
# Actually 7 buttons but one is reserved for onscreen menus

Expand Down
3 changes: 1 addition & 2 deletions data/dth-2452.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=true
Ring=false
Ring2=false
NumRings=0
NumStrips=0
# Actually 5 buttons but one is reserved for onscreen menus

Expand Down
3 changes: 1 addition & 2 deletions data/dti-520.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0
# Actually 11 buttons but the two Ctrl ones send the same scancode

Expand Down
3 changes: 1 addition & 2 deletions data/dtk-1651.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0

[Buttons]
Expand Down
2 changes: 1 addition & 1 deletion data/dtk-1660e-2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
2 changes: 1 addition & 1 deletion data/dtk-1660e.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
NumRings=0
3 changes: 1 addition & 2 deletions data/dtk-2241.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0
# Actually 7 buttons but one is reserved for onscreen menus

Expand Down
3 changes: 1 addition & 2 deletions data/dtk-2451.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0
# Actually 5 buttons but one is reserved for onscreen menus

Expand Down
3 changes: 1 addition & 2 deletions data/dtu-1031.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0

[Buttons]
Expand Down
3 changes: 1 addition & 2 deletions data/dtu-1031x.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,5 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0
3 changes: 1 addition & 2 deletions data/dtu-1141.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0

[Buttons]
Expand Down
3 changes: 1 addition & 2 deletions data/dtu-1141b.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ IntegratedIn=Display
Stylus=true
Reversible=false
Touch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0

[Buttons]
Expand Down
2 changes: 1 addition & 1 deletion data/ek-remote.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Class=Remote

[Features]
Stylus=false
Ring=true
NumRings=1
NumStrips=0
StatusLEDs=Ring

Expand Down
3 changes: 1 addition & 2 deletions data/elan-22e2.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ Stylus=true
Reversible=false
Touch=false
TouchSwitch=false
Ring=false
Ring2=false
NumRings=0
NumStrips=0
3 changes: 1 addition & 2 deletions data/elan-24d8.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ Styli=@generic-with-eraser;
[Features]
Reversible=false
Stylus=true
Ring=false
Ring2=false
NumRings=0
Touch=true
TouchSwitch=false
# StatusLEDs=
Expand Down
2 changes: 1 addition & 1 deletion data/generic.tablet
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ IntegratedIn=Display;System;
[Features]
Reversible=false
Stylus=true
Ring=false
NumRings=0
Loading

0 comments on commit 5b3a3a8

Please sign in to comment.