fix(experimental-extractor): fix various bugs

[timofei-iatsenko]

• update esbuild to 0.21.5
• apply lingui macro on each file as esbuild plugin
• remove buildExternalizeFilter in favour of {packages: external}
• add test to check tree-shking works properly

Description

Implementing ideas from this comment: #1797 (comment)

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Examples update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 7:32am

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.86 KB (0%)
./packages/detect-locale/dist/index.mjs	723 B (0%)
./packages/react/dist/index.mjs	1.65 KB (0%)
./packages/remote-loader/dist/index.mjs	7.26 KB (0%)

[andrii-bodnar]

Thank you!

[AndrewIngram]

Very similar to what I ended up doing! Will try this out once it's released. Alongside the rewrite to not use babel-plugin-macros, I think things will be in a much better place.

[yunsii]

Well, any plan to release a latest next version?

[andrii-bodnar]

@yunsii I was planning to prepare the 5.0.0-next.0 version release on the next week

[andrii-bodnar]

Hi @yunsii, the v5.0.0-next.0 is here 🙂

[yunsii]

I will test it on next week 👌

[yunsii]

Hi @yunsii, the v5.0.0-next.0 is here 🙂

Unfortunately it broken with type syntax like: export const getStaticProps: GetStaticProps = async ctx => {

Reproduction: https://github.com/yunsii/lingui-examples-nextjs-swc-1797/tree/lingui-next

It works after I remove all type syntax 😂

[timofei-iatsenko]

Thanks for reporting, I use TS files in e2e test fixtures but none of them really has anything TS related 🤦‍♂️
Indeed it fails with this error, i was able to reproduce it in tests suite. I will prepare a fix.

[yunsii]

Great, it works after I patched package.

It seems thant we can migrate from @lingui/macro to @lingui/core/macro and @lingui/react/macro progressively? One more question: does @lingui/swc-plugin compatiable with 5.0.0-next.0? 👀

[timofei-iatsenko]

You can use an automatic codemod I prepared to migrate imports, https://github.com/lingui/codemods?tab=readme-ov-file#split-macro-imports

And yes, @lingui/swc-plugin is compatible.

[yunsii]

@lingui/[email protected] is not compatible

[email protected] with babel plugin is okey, commit: yunsii/lingui-examples-nextjs-swc-1797@d6b0a19

[yunsii]

Trans from @lingui/react/macro works with React.Key will print a warning message: Missing message ID, skipping.

But it still extracted.

Reproduction: yunsii/lingui-examples-nextjs-swc-1797@8d3a70d

[timofei-iatsenko]

@lingui/[email protected] is not compatible

[email protected] with babel plugin is okey, commit: yunsii/lingui-examples-nextjs-swc-1797@d6b0a19

My mistake, if you asking about split macro import feature, it's already ported to SWC plugin, but not released yet. So, yes, in terms of new imports, version 4 of swc plugin is incompatible.

[timofei-iatsenko]

Trans from @lingui/react/macro works with React.Key will print a warning message: Missing message ID, skipping.

But it still extracted.

Reproduction: yunsii/lingui-examples-nextjs-swc-1797@8d3a70d

Good catch, please create a separate issue, i will take a look.

[yunsii]

Trans from @lingui/react/macro works with React.Key will print a warning message: Missing message ID, skipping.
But it still extracted.
Reproduction: yunsii/lingui-examples-nextjs-swc-1797@8d3a70d

Good catch, please create a separate issue, i will take a look.

New issue: #1974