fix(experimental-extractor): change default loader to tsx #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we use babel to process only macro in esbuild plugin and left rest of the syntax (including typescript) as-is we have to specify correct loader for esbuild. I choosed tsx loader because it's a superset and do everything what js and ts and tsx loaders could do without relying on file extension
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
|
I was just about to open this issue as I was testing out v5, can confirm that this change fixes the problem I was having. |
|
this one is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we use babel to process only macro in esbuild plugin and left rest of the syntax (including typescript) as-is we have to specify correct loader for esbuild.
I choosed tsx loader because it's a superset and do everything what js and ts and jsx loaders could do without relying on file extension
Description
Types of changes
Fixes #1958 (comment)
Checklist