Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare package configurations for publishing. #478

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Prepare package configurations for publishing. #478

merged 7 commits into from
Mar 1, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Mar 1, 2024

I went over all the Cargo.toml files to get them ready for the upcoming publishing.

  • Enabled publish for vello itself.
  • Bumped vello version to 0.1.0.
  • Removed the workspace version. Every published crate gets its own dedicated version, which for now only means vello & vello_encoding.
  • Added rust-version to document the reality of 1.75 being needed to compile vello at this moment.
  • Excluded some needless files from being bundled when publishing, which is going to reduce the size of the published package by ~1MB !!
  • Promoted some dependencies to workspace dependencies.
  • Reordered some properties to get them into consistent order in all files.

xorgy
xorgy requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I would like that one added comment and clarification on the MSRV.

Cargo.toml Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks reasonable

Cargo.toml Show resolved Hide resolved
crates/tests/Cargo.toml Show resolved Hide resolved
crates/tests/Cargo.toml Outdated Show resolved Hide resolved
examples/headless/Cargo.toml Outdated Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - these are useful improvements

crates/shaders/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@xStrom xStrom mentioned this pull request Mar 1, 2024
Merged
xorgy
xorgy approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xStrom xStrom added this pull request to the merge queue Mar 1, 2024
Merged via the queue into linebender:main with commit 1316bb9 Mar 1, 2024
9 checks passed
@xStrom xStrom deleted the toml branch March 1, 2024 13:47
@DJMcNab DJMcNab mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@xorgy xorgy xorgy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xStrom @xorgy @DJMcNab