masonry: Update MSRV to 1.75 from 1.65 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Vello's MSRV is/will be 1.75 since linebender/vello#478, so I think that's our true minimum
But updating this can't hurt. Thanks.
So I'd recommend changing to 1.75 then landing
The code currently uses some API that is not available in Rust 1.65: * `is_ok_and` from 1.70 * `next_multiple_of` from 1.73 Vello requires 1.75.
waywardmonkeys
force-pushed
the
correct-masonry-msrv
branch
from
ba66eb5 to
6d021fd
Compare
waywardmonkeys
changed the title
|
Good call. Updated and will merge when CI passes (or I wake up in the morning). |
|
(You should be able to merge when ready, which will add to the queue once CI passes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code currently uses some API that is not available in Rust 1.65:
is_ok_andfrom 1.70next_multiple_offrom 1.73Vello requires 1.75.