Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3334 Changing flag with web socket #3362

Merged
merged 10 commits into from
Dec 24, 2024
Merged

TF-3334 Changing flag with web socket #3362

merged 10 commits into from
Dec 24, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Dec 18, 2024 •
edited
Loading

Issue

#3334
#3335

Resolved

  • Remove resynchronisation
  • Remove Email/get of email action when user stay in app list, keep it when user stay in Email View
  • Apply for single email action and multiple email action

Demo

  • Before:
before.mov
  • After
Screen.Recording.2024-12-19.at.16.07.28.mov

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3362.

@hoangdat hoangdat force-pushed the maintenance-v0.14.2 branch from 6494db9 to 617dbe0 Compare December 18, 2024 10:14
@chibenwa
Copy link
Member

TF-3336 Make Echo ping of web socket optional

This commit is not a dependency of the current work. Uneeded in the PR history. Please rebase it away.

@chibenwa
Copy link
Member

Remove Email/get of email action when user stay in app list, keep it when user stay in Email View

Why keep it?

What does it tells us that Email/set update response do not ?

Just. Remove. It.

@dab246
Copy link
Member Author

dab246 commented Dec 18, 2024

Remove Email/get of email action when user stay in app list, keep it when user stay in Email View

Why keep it?

What does it tells us that Email/set update response do not ?

Just. Remove. It.

We don't keep it. It's just still in the works, so it's not checked yet. This isn't the final PR, stay tuned..

@dab246
Copy link
Member Author

dab246 commented Dec 18, 2024

TF-3336 Make Echo ping of web socket optional

This commit is not a dependency of the current work. Uneeded in the PR history. Please rebase it away.

Yes, it hasn't been rebased yet, after we had an emergency change on the maintenance-v0.14.2 branch

@dab246 dab246 changed the title TF-3334 Changing flag with web socket [WIP] TF-3334 Changing flag with web socket Dec 18, 2024
@dab246 dab246 force-pushed the bugfix/tf-3334-changing-flag-with-web-socket branch from d4c8cc4 to 560b826 Compare December 19, 2024 02:43
@dab246 dab246 changed the title [WIP] TF-3334 Changing flag with web socket TF-3334 Changing flag with web socket Dec 19, 2024
This was referenced Dec 19, 2024
Closed
Closed
@dab246 dab246 force-pushed the bugfix/tf-3334-changing-flag-with-web-socket branch from 7b90575 to e321654 Compare December 23, 2024 05:25
@dab246 dab246 requested a review from hoangdat December 23, 2024 08:15
@dab246 dab246 requested a review from hoangdat December 23, 2024 09:11
@hoangdat hoangdat force-pushed the bugfix/tf-3334-changing-flag-with-web-socket branch from 4082c67 to 8487a68 Compare December 23, 2024 15:54
@hoangdat
Copy link
Member

hoangdat commented Dec 23, 2024 •
edited by dab246
Loading

  • Inbox not display exact emails after come back from search
Screenrecorder-2024-12-24-00-15-27-288.mp4

Reproduce

  1. Stay in Inbox
  2. Search
  3. type "hello"
  4. Mark as star an email
  5. Click to back button
  6. Inbox display with wrong emails list

@dab246
Copy link
Member Author

dab246 commented Dec 24, 2024

  • Inbox not display exact emails after come back from search

Fixed.

  • Mobile:

... demo updated.....

  • Web responsive:

... demo updated.....

hoangdat
hoangdat approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@dab246 dab246 force-pushed the bugfix/tf-3334-changing-flag-with-web-socket branch from 8e1e2e8 to 2e47f18 Compare December 24, 2024 07:17
@dab246 dab246 requested a review from hoangdat December 24, 2024 07:17
@dab246
Copy link
Member Author

dab246 commented Dec 24, 2024

please rebase

Done

@hoangdat hoangdat merged commit 420df05 into maintenance-v0.14.2 Dec 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@chibenwa chibenwa Awaiting requested review from chibenwa

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees
No one assigned
Labels
customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dab246 @chibenwa @hoangdat @tddang-linagora