Skip to content

Commit

Permalink
fixup! fixup! fixup! TF-3334 Add more concurrence test cases for WebS…
Browse files Browse the repository at this point in the history
…ocketQueueHandler
  • Loading branch information
dab246 committed Dec 24, 2024
1 parent 756786d commit 8e1e2e8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1465,10 +1465,6 @@ class MailboxDashBoardController extends ReloadableController with UserSettingPo
void dispatchRoute(DashboardRoutes route) {
log('MailboxDashBoardController::dispatchRoute(): $route');
dashboardRoute.value = route;

if (dashboardRoute.value == DashboardRoutes.searchEmail) {
searchController.activateSimpleSearch();
}
}

@override
Expand Down
5 changes: 1 addition & 4 deletions lib/features/thread/presentation/thread_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,7 @@ class ThreadController extends BaseController with EmailActionController {
return Future.value();
}

if (searchController.isSearchEmailRunning &&
mailboxDashBoardController.dashboardRoute.value == DashboardRoutes.thread) {
if (searchController.isSearchEmailRunning) {
await _refreshChangeSearchEmail();
} else {
await _refreshChangeListEmail();
Expand All @@ -568,8 +567,6 @@ class ThreadController extends BaseController with EmailActionController {
),
beforeOption: const None(),
);
searchController.activateSimpleSearch();

final searchViewState = await _searchEmailInteractor.execute(
_session!,
_accountId!,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import 'package:tmail_ui_user/features/login/domain/usecases/delete_credential_i
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/action/dashboard_action.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/mailbox_dashboard_controller.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/controller/search_controller.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/model/dashboard_routes.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/model/search/email_sort_order_type.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/model/search/search_email_filter.dart';
import 'package:tmail_ui_user/features/manage_account/data/local/language_cache_manager.dart';
Expand Down Expand Up @@ -288,7 +287,6 @@ void main() {
when(mockMailboxDashBoardController.viewState).thenReturn(Rx(Right(UIState.idle)));
when(mockMailboxDashBoardController.filterMessageOption).thenReturn(Rx(FilterMessageOption.all));
when(mockMailboxDashBoardController.currentEmailState).thenReturn(State('old-state'));
when(mockMailboxDashBoardController.dashboardRoute).thenReturn(Rx(DashboardRoutes.thread));
when(mockSearchController.searchState).thenReturn(Rx(SearchState.initial()));
when(mockSearchController.isAdvancedSearchViewOpen).thenReturn(RxBool(false));
when(mockSearchController.isSearchEmailRunning).thenReturn(true);
Expand Down

0 comments on commit 8e1e2e8

Please sign in to comment.