Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod+lightning+chainkit: update to lnd v0.17.1-beta.rc1 and expose GetBlockHeader #161

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

jharveyb
Copy link
Contributor

@jharveyb jharveyb commented Nov 7, 2023

Pull Request Checklist

Only bumping the lnd version to v0.17.1-beta.rc1 and exposing the GetBlockHeader call.

IIUC this should go in a new branch, not master.

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@bhandras
Copy link
Member

bhandras commented Nov 8, 2023

Could you lease open against this branch: https://github.com/lightninglabs/lndclient/tree/lnd-17-0

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending changing target branch to lnd-17-0.

chainkit_client.go Show resolved Hide resolved
@jharveyb jharveyb changed the base branch from master to lnd-17-0 November 9, 2023 17:56
@jharveyb jharveyb merged commit 7048b84 into lightninglabs:lnd-17-0 Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants