chain_bridge: fetch block headers over blocks when verifying proofs #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
force-pushed
the
getblockheader_verifier
branch
from
3c4375c to
6013359
Compare
|
|
Have tested that this uses |
jharveyb
force-pushed
the
getblockheader_verifier
branch
from
6013359 to
422a004
Compare
|
Should not merge until we get a tagged version for |
In this commit, we update the header verifier to use the new GetBlockHeader RPC when supported, and avoid fetching a full block. This improves the reliability of proof validation and universe sync for light clients.
jharveyb
force-pushed
the
getblockheader_verifier
branch
from
422a004 to
8a52e70
Compare
|
Bumped to appropriate |
ffranr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315 , #613 . Depends on lightninglabs/lndclient#161 .
This makes use of the
GetBlockHeaderRPC now available in LND v0.17.1 to avoid fetching a full block during proof verification.VerifyBlockis used in theHeaderVerifier, which never made use of the full block. This should be safe to change for all places where aHeaderVerifieris used, so this is added without adding a separate implementation ofHeaderVerifier.Confirmed that the
GetBlockcalls are no longer made by runningtapdwith this PR backed by LND v0.17.1-beta-rc1 and manually syncing.