-
Notifications
You must be signed in to change notification settings - Fork 371
Meeting Notes 2020 12 28
Chair: @devrandom
- ariard
- devrandom
- jkczyz
- arik-so
- Matt Corallo
- Valentine Wallace
- Brian Mancini
- 0.0.13 (#752/#646/#761/#762)
- node sample (#763)
Progress a bit slow due to holidays.
PR standards:
-
When to put PRs in milestones: when they block the release. PRs that are not a deliverable for any particular release will remain without milestone assigned (but can still be high priority for other reasons - e.g. important cleanup).
-
smaller PRs (but not always possible)
-
a couple of people felt that some review items can be postponed to followup PRs
-
"Standard of care" for PRs: For new subsystem like gossips or routing improvements, okay to be less-than-perfect. For critical code paths, state machine, onchain, key management, "production quality" readiness.
-
While working through a PR, author may create a followup PR with followup tasks that are not critical for keeping master solid.
@jkczyz to split 763 (node sample and block sync) into bite size chunks and hopefully parallelize.
Need to "write down more" - maybe the new wiki will encourage.
Moved meeting notes to wiki (this page).