This repository has been archived by the owner on May 26, 2022. It is now read-only.
fix: call InterceptSecured earlier; drop conn. #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This would fix the bug for QUIC, but not for TLS.
In #155 (comment) I've argued that InterceptSecured belongs in the security layer, not in the transport layer. What are your thoughts on that?
raulk
commented
May 21, 2020
| @@ -50,8 +50,7 @@ func (c *filteredConn) ReadFrom(b []byte) (n int, addr net.Addr, rerr error) { | |||
| } | |||
|
|
|||
| connAddrs := &connAddrs{lmAddr: c.lmAddr, rmAddr: rmAddr} | |||
|
|
|||
| if c.gater.InterceptAccept(connAddrs) { | |||
| if c.gater != nil && c.gater.InterceptAccept(connAddrs) { | |||
There was a problem hiding this comment.
Fixed a potential nil pointer panic here.
raulk
commented
May 21, 2020
| ma "github.com/multiformats/go-multiaddr" | ||
| ) | ||
|
|
||
| func BenchmarkInterceptSecured(b *testing.B) { |
There was a problem hiding this comment.
Figured we might as well write a little benchmark to know how much state is being constructed by QUIC after a successful handshake, which we could prevent by blocking denied connections earlier.
TL;DR: we're looking at a 20% difference in allocs (1000+ allocs), and 10% difference in bytes (50kB per op).
This PR
goos: darwin
goarch: amd64
pkg: github.com/libp2p/go-libp2p-quic-transport
BenchmarkInterceptSecured
BenchmarkInterceptSecured-8 694 1673938 ns/op 497751 B/op 4394 allocs/op
PASS
Process finished with exit code 0
PR #157
goos: darwin
goarch: amd64
pkg: github.com/libp2p/go-libp2p-quic-transport
BenchmarkInterceptSecured
BenchmarkInterceptSecured-8 670 1760618 ns/op 544251 B/op 5436 allocs/op
PASS
Process finished with exit code 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155.