Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

fix a potential nil-pointer panic. #158

Merged
merged 1 commit into from
May 22, 2020
Merged

fix a potential nil-pointer panic. #158

merged 1 commit into from
May 22, 2020

Conversation

raulk
Copy link
Member

@raulk raulk commented May 22, 2020

Cherry-picked from #156, while we sort the discussion out.

@raulk raulk merged commit eda7485 into master May 22, 2020
@raulk raulk deleted the fix/nil-pointer branch May 22, 2020 09:33
@marten-seemann
Copy link
Collaborator

marten-seemann commented May 22, 2020

I don’t think this is necessary. The filtered conn is only created when we use a gater:

func newReuseConn(conn net.PacketConn, gater connmgr.ConnectionGater) *reuseConn {
if gater != nil {
conn = newFilteredConn(conn, gater)
}

Can you please revert this PR?

@raulk
Copy link
Member Author

raulk commented May 22, 2020

Oh, right. The filteredConn is rather confusing.

raulk added a commit that referenced this pull request May 22, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants