cmd: Make a debug listen address optional

cmd/admin/admin.go

@@ -48,7 +48,7 @@ func newAdmin(configFile string, dryRun bool) (*admin, error) {
 		return nil, fmt.Errorf("parsing config file: %w", err)
 	}
 
-	scope, logger, oTelShutdown := cmd.StatsAndLogging(c.Syslog, c.OpenTelemetry, c.Admin.DebugAddr)
+	scope, logger, oTelShutdown := cmd.StatsAndLogging(c.Syslog, c.OpenTelemetry, "")
 	defer oTelShutdown(context.Background())
 	logger.Info(cmd.VersionString())
 

cmd/admin/main.go

@@ -31,6 +31,7 @@ type Config struct {
 		RAService *cmd.GRPCClientConfig
 		SAService *cmd.GRPCClientConfig
 
+		// Deprecated: DebugAddr is no longer used.
 		DebugAddr string
 
 		Features features.Config

cmd/shell.go

@@ -261,6 +261,12 @@ func newVersionCollector() prometheus.Collector {
 
 func newStatsRegistry(addr string, logger blog.Logger) prometheus.Registerer {
 	registry := prometheus.NewRegistry()
+
+	if addr == "" {
+		logger.Info("No debug listen address specified")
+		return registry
+	}
+
 	registry.MustRegister(collectors.NewGoCollector())
 	registry.MustRegister(collectors.NewProcessCollector(
 		collectors.ProcessCollectorOpts{}))
@@ -287,10 +293,6 @@ func newStatsRegistry(addr string, logger blog.Logger) prometheus.Registerer {
 		ErrorLog: promLogger{logger},
 	}))
 
-	if addr == "" {
-		logger.Err("Debug listen address is not configured")
-		os.Exit(1)
-	}
 	logger.Infof("Debug server listening on %s", addr)
 
 	server := http.Server{

test/config-next/admin.json

@@ -4,7 +4,6 @@
 			"dbConnectFile": "test/secrets/revoker_dburl",
 			"maxOpenConns": 1
 		},
-		"debugAddr": ":8014",
 		"tls": {
 			"caCertFile": "test/certs/ipki/minica.pem",
 			"certFile": "test/certs/ipki/admin-revoker.boulder/cert.pem",

test/config-next/sfe.json

@@ -1,7 +1,6 @@
 {
 	"sfe": {
 		"listenAddress": "0.0.0.0:4003",
-		"debugAddr": ":8015",
 		"timeout": "30s",
 		"shutdownStopTimeout": "10s",
 		"tls": {