admin: Add debug-addr CLI flag #7840
Conversation
If provided, the CLI flag will override the value in the config file. Use the CLI flag to de-conflict parallel integration tests. Fixes #7838
cmd/admin/main.go
Outdated
| @@ -92,6 +93,7 @@ func main() { | |||
| // they're present. | |||
| configFile := flag.String("config", "", "Path to the configuration file for this service (required)") | |||
| dryRun := flag.Bool("dry-run", true, "Print actions instead of mutating the database") | |||
| debugAddr := flag.String("debug-addr", "", "Debug server address override") | |||
There was a problem hiding this comment.
If we're removing the need for debugAddr in newStatsRegistry, then I think there's no need to add this CLI flag here anymore.
There was a problem hiding this comment.
I agree with this. And above, in admin.go lines 50-52.
There was a problem hiding this comment.
The newest commit deprecates and stops any use of debugAddr from the config file, and just uses the CLI flag. Is this OK, or are you saying it would make sense to stop plumbing through any debugAddr at all for admin?
cmd/admin/main.go
Outdated
| @@ -92,6 +93,7 @@ func main() { | |||
| // they're present. | |||
| configFile := flag.String("config", "", "Path to the configuration file for this service (required)") | |||
| dryRun := flag.Bool("dry-run", true, "Print actions instead of mutating the database") | |||
| debugAddr := flag.String("debug-addr", "", "Debug server address override") | |||
There was a problem hiding this comment.
I agree with this. And above, in admin.go lines 50-52.
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
If provided, the CLI flag will override the value in the config file.
Use the CLI flag to de-conflict parallel integration tests.
Make debug addresses optional for all cmds.
Fixes #7838