Check registry file hash before downloading #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewoldag
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
This looks good to me. I'm glad that you've got unit tests in place, but I'm not fully confident all the logic is exercised (I could be wrong). As mentioned in the comment, it might be worth expanding the unit tests, or possibly just noting which code paths aren't covered in some comments for later implementation.
Closed
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 23.26% 22.94% -0.32%
==========================================
Files 14 47 +33
Lines 662 5883 +5221
Branches 0 934 +934
==========================================
+ Hits 154 1350 +1196
- Misses 508 4533 +4025 ☔ View full report in Codecov by Sentry. |
…c-frameworks/lephare-dev into issue/54/registry-hash-file
…mprove readability
drewoldag
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Nice, I like the way you've documented the logic and the tests that cover it.
drewoldag
reviewed
Apr 24, 2024
drewoldag
approved these changes
Apr 24, 2024
drewoldag
reviewed
Apr 25, 2024
| else: | ||
| print(f"Local registry file is not up to date: {local_registry_file}") | ||
| return False | ||
| return remote_hash_response.text.strip() == local_registry_hash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #54; checks the hash of the local registry file against the hash of the remote registry file to avoid unnecessary re-downloading of the registry file.
Note - the docs are failing because I've renamed the remote
data-registry.txttodata_registry.txtto match our usage in lephare (default behavior is to save this file asdata_registry.txt). Until we merge lephare-photoz/lephare-data#12, we won't be able to find this new file.